Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document standard metadata entries. #61941

Merged
merged 7 commits into from
Oct 12, 2020
Merged

Document standard metadata entries. #61941

merged 7 commits into from
Oct 12, 2020

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Sep 3, 2020

We standardized on some metadata entries that we plan to later leverage
in Kibana in order to provide a better out-of-the-box experience, e.g.
different visualizations make sense on gauges and counters.

We standardize on some metadata entries that we plan to later leverage
in Kibana in order to provide a better out-of-the-box experience, e.g.
different visualizations make sense on gauges and counters.
@jpountz jpountz added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 labels Sep 3, 2020
@jpountz jpountz requested a review from debadair September 3, 2020 17:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)


The type of metric. Recognizes `"gauge"` and `"counter"`. By default, fields
are assumed to not be a metric. This information should only be specified on
numeric fields.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to explain what gauges and counters are in here. Something like:

The type of metric for time series data. Options are none, "gauge" and "counter".

A gauge is a number representing a point in time that can go up and down.

A counter is a number representing a cumulative amount and is always increasing. Counters can reset to 0 occasionally.


ratio::

Whether the field is a ratio. Recognizes `true` and `false` (default). The

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Whether the field is a ratio. Recognizes `true` and `false` (default). The
Whether the field is a ratio or percent. Recognizes `true` and `false` (default). The

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was that we always use ratios in the data we produce, never percentages (ie. ratio * 100), is this assumption wrong? If we have both, do we need to be able to make the distinction via this metadata so that Kibana would know?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roncohen @ruflin and I had a small discussion about this yesterday. We see how this can be confusing for users, so we agreed this could be the best approach:

Having only percent stored as a unit (no need for a ratio flag in meta), where the value is expected to be in the [0-1] notation. This is how Metricbeat stores percentages today.

WDYT?

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some editorial suggestions.

docs/reference/mapping/params/meta.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/params/meta.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/params/meta.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/params/meta.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/params/meta.asciidoc Outdated Show resolved Hide resolved
@jpountz
Copy link
Contributor Author

jpountz commented Oct 8, 2020

Thanks @debadair for the help!
We have had a couple discussions about the conventions we want in the metrics working group and decided to remove ratio and treat percent as a unit instead.

Copy link

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpountz jpountz merged commit 62348b6 into elastic:master Oct 12, 2020
jpountz added a commit to jpountz/elasticsearch that referenced this pull request Oct 12, 2020
We standardize on some metadata entries that we plan to later leverage
in Kibana in order to provide a better out-of-the-box experience, e.g.
different visualizations make sense on gauges and counters.
jpountz added a commit that referenced this pull request Oct 13, 2020
We standardize on some metadata entries that we plan to later leverage
in Kibana in order to provide a better out-of-the-box experience, e.g.
different visualizations make sense on gauges and counters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Meta label for search team v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants