-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tier preference when mounting #63204
Merged
jasontedor
merged 1 commit into
elastic:master
from
jasontedor:mount-searchable-snapshots-prefer-cold
Oct 3, 2020
Merged
Add tier preference when mounting #63204
jasontedor
merged 1 commit into
elastic:master
from
jasontedor:mount-searchable-snapshots-prefer-cold
Oct 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a tier preference when mounting a searchable snapshot. This sets a preference that a searchable snapshot is mounted to a node with the cold role if one exists, then the warm role, then the hot role, assuming that no other allocation rules are in place. This means that by default, searchable snapshots are mounted to a node with the cold role. Note that depending on how we implement frozen functionality of searchable snapshots (not pre-cached/not fully-cached), we might need to adjust this to prefer frozen if mounting a not pre-cached/fully-cached searchable snapshot versus mounting a pre-cached/fully-cached searchable snapshot. This is a later concern since neither this nor the frozen role are implemented currently.
jasontedor
added
>enhancement
:Distributed Coordination/Allocation
All issues relating to the decision making around placing a shard (both master logic & on the nodes)
v8.0.0
v7.10.0
labels
Oct 2, 2020
Pinging @elastic/es-distributed (:Distributed/Allocation) |
elasticmachine
added
the
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
label
Oct 2, 2020
Note the ILM covers this when using the |
henningandersen
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
jasontedor
added a commit
that referenced
this pull request
Oct 3, 2020
This commit adds a tier preference when mounting a searchable snapshot. This sets a preference that a searchable snapshot is mounted to a node with the cold role if one exists, then the warm role, then the hot role, assuming that no other allocation rules are in place. This means that by default, searchable snapshots are mounted to a node with the cold role. Note that depending on how we implement frozen functionality of searchable snapshots (not pre-cached/not fully-cached), we might need to adjust this to prefer frozen if mounting a not pre-cached/fully-cached searchable snapshot versus mounting a pre-cached/fully-cached searchable snapshot. This is a later concern since neither this nor the frozen role are implemented currently.
Thanks Jason |
tlrx
added a commit
that referenced
this pull request
Oct 22, 2020
In #63204 we added a data tier preference for searchable snapshot indices (cold > warm > hot). Since these indices can use a system index (.snapshot-blob-cache) for their recoveries I think it makes sense that this internal index share the same tier preference.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Oct 22, 2020
…ic#64004) In elastic#63204 we added a data tier preference for searchable snapshot indices (cold > warm > hot). Since these indices can use a system index (.snapshot-blob-cache) for their recoveries I think it makes sense that this internal index share the same tier preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Allocation
All issues relating to the decision making around placing a shard (both master logic & on the nodes)
>enhancement
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v7.10.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a tier preference when mounting a searchable snapshot. This sets a preference that a searchable snapshot is mounted to a node with the cold role if one exists, then the warm role, then the hot role, assuming that no other allocation rules are in place. This means that by default, searchable snapshots are mounted to a node with the cold role.
Note that depending on how we implement frozen functionality of searchable snapshots (not pre-cached/not fully-cached), we might need to adjust this to prefer frozen if mounting a not pre-cached/fully-cached searchable snapshot versus mounting a pre-cached/fully-cached searchable snapshot. This is a later concern since neither this nor the frozen role are implemented currently.