Return an error when a rate aggregation cannot calculate bucket sizes #65429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases when the rate aggregation is not a child of a date histogram aggregation, it is not possible to determine the actual size of the date histogram bucket. In this case the rate aggregation now throws an exception. Closes elastic#63703
imotov
added
>bug
WIP
:Analytics/Aggregations
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
reviewed
Nov 24, 2020
| @@ -609,16 +609,22 @@ public String toString() { | |||
|
|
|||
| private abstract class TimeUnitPreparedRounding extends PreparedRounding { | |||
| @Override | |||
| public double roundingSize(long utcMillis, DateTimeUnit timeUnit) { | |||
| public double roundingSize(Long utcMillis, DateTimeUnit timeUnit) { | |||
| if (timeUnit.isMillisBased == unit.isMillisBased) { | |||
There was a problem hiding this comment.
Any chance you could group this so unit.isMillisBased is called once? I think it might be a bit easier to read if you juggle the "arms" of the if statement.
| @@ -609,16 +609,22 @@ public String toString() { | |||
|
|
|||
| private abstract class TimeUnitPreparedRounding extends PreparedRounding { | |||
| @Override | |||
| public double roundingSize(long utcMillis, DateTimeUnit timeUnit) { | |||
| public double roundingSize(Long utcMillis, DateTimeUnit timeUnit) { | |||
There was a problem hiding this comment.
I wonder if it'd be easier to read if there were two methods? I'd kind of feel more comfortable having two just so you don't need auto-boxing. It might not make a huge difference, but in general Rounding doesn't its best not to allocate stuff. I think this method doesn't have to be so efficient, but still.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases when the rate aggregation is not a child of a date histogram
aggregation, it is not possible to determine the actual size of the date
histogram bucket. In this case the rate aggregation now throws an exception.
Closes #63703