Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] URI parts processor #65695

Merged

Conversation

danhermann
Copy link
Contributor

Adds documentation for the ingest processor added in #65150.

@danhermann danhermann added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.11.0 labels Dec 1, 2020
@danhermann danhermann requested a review from jrodewig December 1, 2020 17:58
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Dec 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few suggestions for clarity but nothing I'd consider blocking. Thanks @danhermann!

docs/reference/ingest/processors/uri-parts.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/uri-parts.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/uri-parts.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/uri-parts.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/uri-parts.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
@danhermann
Copy link
Contributor Author

@jrodewig, thanks for the review and the suggestions. They definitely improved my rambling circumlocutions. 😃

@danhermann danhermann merged commit 90d25d6 into elastic:master Dec 2, 2020
@danhermann danhermann deleted the docs_for_65150_uri_parts_processor branch December 2, 2020 13:22
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Mar 12, 2021
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Mar 12, 2021
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Mar 12, 2021
danhermann added a commit that referenced this pull request Mar 12, 2021
danhermann added a commit that referenced this pull request Mar 12, 2021
danhermann added a commit that referenced this pull request Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants