Remove grace period from license expiration check #67316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License expiration checking currently has a 7 day grace period. When a license expires, the licensing code acts as if it is not yet expired. This was originally intended to protect users who may accidentally end up letting their license expire from the pain of their licensed features ceasing to work. However, the grace period effectively shifts the license expiration by a week, resulting in confusion since the actual license expiration date is not accurate. It also is less of a concern now as not only do we emit several warnings for upcoming license expiration, but the new license can be downloaded and installed quickly by the user through the support portal. This commit removes the license grace period altogether.
rjernst
added
>breaking
:Security/License
|
Pinging @elastic/es-security (Team:Security) |
|
Note that I have marked this as |
|
Thanks @rjernst, I agree it is not a breaking change for users as the grace period is not something they know/rely on. |
|
@elasticmachine update branch |
rjernst
added a commit
that referenced
this pull request
Feb 12, 2021
License expiration checking currently has a 7 day grace period. When a license expires, the licensing code acts as if it is not yet expired. This was originally intended to protect users who may accidentally end up letting their license expire from the pain of their licensed features ceasing to work. However, the grace period effectively shifts the license expiration by a week, resulting in confusion since the actual license expiration date is not accurate. It also is less of a concern now as not only do we emit several warnings for upcoming license expiration, but the new license can be downloaded and installed quickly by the user through the support portal. This commit removes the license grace period altogether.
|
I will put this under "Enhancements" in the release notes so that it's not the first thing that users see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License expiration checking currently has a 7 day grace period. When a
license expires, the licensing code acts as if it is not yet expired.
This was originally intended to protect users who may accidentally end up
letting their license expire from the pain of their licensed features
ceasing to work. However, the grace period effectively shifts the
license expiration by a week, resulting in confusion since the actual
license expiration date is not accurate. It also is less of a concern
now as not only do we emit several warnings for upcoming license
expiration, but the new license can be downloaded and installed quickly
by the user through the support portal.
This commit removes the license grace period altogether.