-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include min/max/average file size in Searchable Snapshots Stats API #70294
Conversation
Pinging @elastic/es-distributed (Team:Distributed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful to add this info to the stats API. I've left some minor comments w.r.t. consistency between total and min/max fields. I'm also wondering we should fold CacheIndexInputStats.{total_size,min_size,max_size,avg_size}
into a size section (i.e. have fields "total,min,max,avg" under a "size" object)
...main/java/org/elasticsearch/xpack/core/searchablesnapshots/SearchableSnapshotShardStats.java
Outdated
Show resolved
Hide resolved
...plugin/searchable-snapshots/src/main/java/org/elasticsearch/index/store/IndexInputStats.java
Outdated
Show resolved
Hide resolved
@ywelsch thanks for your feedback. I've updated the code, can you please have another look when you have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Yannick |
…lastic#70294) This commit adds the minimum, maximum and average length of files in the Searchable Snapshots Stats API.
This pull request adds the minimum, maximum and average length of files in the Searchable Snapshots Stats API:
These information are useful in understanding why some data is still being read from the blob store when the cached blob in
.snapshot-blob-cache
should have been sufficient to server all the read operations.