Map data tiers roles onto DATA legacy role for <7.3 #71628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
requested changes
Apr 13, 2021
There was a problem hiding this comment.
Thanks for taking a look at this @andreidan! I think we might be able to do it in a simpler way, what do you think?
server/src/main/java/org/elasticsearch/cluster/node/DiscoveryNode.java
Outdated
Show resolved
Hide resolved
dakrone
approved these changes
Apr 13, 2021
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 14, 2021
Map data tiers roles onto DATA legacy role for <7.3 (cherry picked from commit 55e003d) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan
added a commit
that referenced
this pull request
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rolling upgrade from <7.3 to ≥7.10 would fail to map the data
tiers node roles to the
DATArole. This PR adjusts the logic tocorrectly map the data tier node roles (or rather, all node roles
that can contain data) onto the
DATArole.Fixes #71464