Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force execution of delete index requests #7799

Closed
wants to merge 1 commit into from

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Sep 19, 2014

The management threadpool is now bouned and can reject executions.
We should make sure that delete index operations are forced on the
threadpool.

The management threadpool is now bouned and can reject executions.
We should make sure that delete index operations are forced on the
threadpool.
@s1monw
Copy link
Contributor Author

s1monw commented Sep 19, 2014

@martijnvg / @kimchy can you take a look

@martijnvg
Copy link
Member

LGTM. I wonder if we should also do this in MetaDataDeleteIndexService#createIndex() ?

@s1monw
Copy link
Contributor Author

s1monw commented Sep 20, 2014

I wonder if we should also do this in MetaDataDeleteIndexService#createIndex()

so I didn't do this since my rational behind this change is that we should clear resources even if we are under pressure since it might be the source of the pressure. Yet this is not true for creating resources so I think we shouldn't do that for the create case?

@kimchy
Copy link
Member

kimchy commented Sep 20, 2014

@s1monw I am concerned that just queuing will not help much? if there is some reason that the server is under load and can't process metadata requests, and indices are not the reason for it (network, something else), then we get back to the original reason of why the management TP because bounded in the first place. With force queue of the delete request, then we will just keep on increasing the queue?

@s1monw
Copy link
Contributor Author

s1monw commented Sep 24, 2014

like the reason for an overloaded management queue is too many mapping updates. I think we should force the execution of the delete calls here since they free resources. if you find a better way to make the delete index reliable and not rejected just because somebody goes wild with dynamic mappings is fine with me too :)

@clintongormley clintongormley changed the title [CORE] Force execution of delete index requests Internal: Force execution of delete index requests Sep 26, 2014
@s1monw
Copy link
Contributor Author

s1monw commented Oct 7, 2014

we moved back to a scaling threadpool here so I am closing this since it's invalid

@s1monw s1monw closed this Oct 7, 2014
@jpountz jpountz removed the review label Oct 21, 2014
@clintongormley clintongormley changed the title Internal: Force execution of delete index requests Force execution of delete index requests Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants