Optimize DataTierAllocationDecider Further #78235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decider is still by far the most expensive component of reroute operations. Optimizing away some more costly allocations and slow stream loops.
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
97 tasks
henningandersen
approved these changes
Sep 23, 2021
| @@ -90,8 +91,7 @@ public void validate(String value, Map<Setting<?>, Object> settings, boolean exi | |||
| "] tier preference may be used for partial searchable snapshots (got: [" + value + "])"); | |||
| } | |||
| } else { | |||
| String[] split = value.split(","); | |||
| if (Arrays.stream(split).anyMatch(DATA_FROZEN::equals)) { | |||
| if (FROZEN_TIER_PATTERN.matcher(value).find()) { | |||
There was a problem hiding this comment.
I am not really sure about this bit, might run faster, might not?
Perhaps we can add a test validating that just doing value.indexOf(DATA_FROZEN) is safe, i.e., that there are no other tiers starting with DATA_FROZEN?
There was a problem hiding this comment.
Jup see d62ad36 that should be much faster and is more fun to read as well :)
|
Thanks Henning! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 23, 2021
This decider is still by far the most expensive component of reroute operations. Optimizing away some more costly allocations and slow stream loops.
original-brownbear
added a commit
that referenced
this pull request
Sep 23, 2021
dakrone
reviewed
Sep 23, 2021
.../main/java/org/elasticsearch/xpack/cluster/routing/allocation/DataTierAllocationDecider.java
Show resolved
Hide resolved
|
My other concern about this is that without any code comments about why these changes were made, we run the risk of accidentally undoing these changes in a subsequent PR. (something like "oh, I like streams, I'll use those rather than this old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decider is still by far the most expensive component of reroute operations on very large clusters.
Optimizing away some more costly allocations and slow stream loops.