-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation docs for voting config excls. API #78821
Add deprecation docs for voting config excls. API #78821
Conversation
In elastic#55291 we deprecated the older form of the voting config exclusions API but forgot to record this deprecation in the docs. This commit adds the missing docs.
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DaveCTurner. This looks good overall, but there are a few items we'll want to address before merging. One of them could make backports messy.
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @DaveCTurner!
In #55291 we deprecated the older form of the voting config exclusions API but forgot to record this deprecation in the docs. This commit adds the missing docs. Co-authored-by: James Rodewig <james.rodewig@elastic.co>
In #55291 we deprecated the older form of the voting config exclusions API but forgot to record this deprecation in the docs. This commit adds the missing docs. Co-authored-by: James Rodewig <james.rodewig@elastic.co>
In #55291 we deprecated the older form of the voting config exclusions API but forgot to record this deprecation in the docs. This commit adds the missing docs. Co-authored-by: James Rodewig <james.rodewig@elastic.co>
In #55291 we deprecated the older form of the voting config exclusions API but forgot to record this deprecation in the docs. This commit adds the missing docs. Co-authored-by: James Rodewig <james.rodewig@elastic.co>
In #55291 we deprecated the older form of the voting config exclusions API but forgot to record this deprecation in the docs. This commit adds the missing docs. Co-authored-by: James Rodewig <james.rodewig@elastic.co>
In #55291 we deprecated the older form of the voting config exclusions API but forgot to record this deprecation in the docs. This commit adds the missing docs. Co-authored-by: James Rodewig <james.rodewig@elastic.co>
In #55291 we deprecated the older form of the voting config exclusions API but forgot to record this deprecation in the docs. This commit adds the missing docs. Co-authored-by: James Rodewig <james.rodewig@elastic.co>
In #55291 we deprecated the older form of the voting config exclusions API but forgot to record this deprecation in the docs. This commit adds the missing docs. Co-authored-by: James Rodewig <james.rodewig@elastic.co>
In #55291 we deprecated the older form of the voting config exclusions API but forgot to record this deprecation in the docs. This commit adds the missing docs. Co-authored-by: James Rodewig <james.rodewig@elastic.co>
In #55291 we deprecated the older form of the voting config exclusions
API but forgot to record this deprecation in the docs. This commit adds
the missing docs.