Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code related to Beats Central Management #80107

Closed
wants to merge 4 commits into from
Closed

Remove code related to Beats Central Management #80107

wants to merge 4 commits into from

Conversation

justincr-elastic
Copy link
Contributor

@justincr-elastic justincr-elastic commented Oct 29, 2021 •
edited
Loading

Removes code originally introduced by #30520

Closes #76330

@justincr-elastic justincr-elastic marked this pull request as ready for review November 1, 2021 15:13
@justincr-elastic justincr-elastic added the Team:Security Meta label for security team label Nov 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@justincr-elastic justincr-elastic added >refactoring :Security/Security Security issues without another label labels Nov 1, 2021
@justincr-elastic justincr-elastic self-assigned this Nov 3, 2021
tvernum
tvernum requested changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, removing a builtin role is a breaking change, and we can't do that without a period of deprecation.

We need to keep the beats_admin role, but deprecate it.
We can remove the license related code.

...high-level/src/test/java/org/elasticsearch/client/documentation/SecurityDocumentationIT.java Outdated Show resolved Hide resolved
@justincr-elastic
Copy link
Contributor Author

https://www.elastic.co/guide/en/beats/filebeat/8.0/configuration-central-management.html
"Starting in version 7.14, Beats central management has been removed."

@tvernum, since it has been removed from Kibana, is it ok to do ahead and remove it from Elasticsearch 8.x?

@tvernum
Copy link
Contributor

tvernum commented Nov 8, 2021

No, even though the functionality that it was intended to support has been removed from Kibana, the role itself exists in Elasticsearch and hasn't been marked as deprecated, nor was it ever marked as beta (which the Kibana functionality was).

We really do need to deprecate the role instead of removing it.

@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
@rdnm rdnm removed the request for review from jkakavas March 1, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvernum tvernum tvernum requested changes

Assignees

@justincr-elastic justincr-elastic

Labels
>refactoring :Security/Security Security issues without another label Team:Security Meta label for security team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove code related to Beats Central Management
6 participants
@justincr-elastic @elasticmachine @tvernum @mark-vieira @elasticsearchmachine @salvatore-campagna