Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Update snapshot defaults for system indices #81226

Merged
merged 3 commits into from
Dec 8, 2021
Merged

[DOCS] Update snapshot defaults for system indices #81226

merged 3 commits into from
Dec 8, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Dec 1, 2021 •
edited
Loading

Updates the snapshot and restore docs for #79670.

Closes #81183

Preview

@jrodewig jrodewig marked this pull request as ready for review December 2, 2021 16:11
@jrodewig jrodewig added v8.0.0-beta1 :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes labels Dec 2, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Dec 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

williamrandolph
williamrandolph approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@williamrandolph williamrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jrodewig jrodewig mentioned this pull request Dec 3, 2021
Merged
gwbrown
gwbrown approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

I wonder (not for this PR), could we formalize the definition of a "regular" index somewhere if we haven't already? If we have, I'm going to start using that term in error messages and warnings about system indices.

@jrodewig jrodewig mentioned this pull request Dec 8, 2021
Closed
@jrodewig
Copy link
Contributor Author

jrodewig commented Dec 8, 2021

I wonder (not for this PR), could we formalize the definition of a "regular" index somewhere if we haven't already? If we have, I'm going to start using that term in error messages and warnings about system indices.

Good point. I opened #81531 to track that work.

@jrodewig jrodewig merged commit 1519bb6 into elastic:master Dec 8, 2021
@jrodewig jrodewig deleted the docs__snapshot-system-index-defaults branch December 8, 2021 15:15
@jrodewig jrodewig mentioned this pull request Dec 8, 2021
Merged
jrodewig added a commit to elastic/kibana that referenced this pull request Dec 8, 2021
@jrodewig
Update snapshot docs for new system index defaults (#120174)
26c8703 
With elastic/elasticsearch#79670, you can only include system indices in a snapshot using feature states. This updates some references to taking a snapshots of the `.kibana*` system indices.

Relates to elastic/elasticsearch#81226
elasticsearchmachine pushed a commit that referenced this pull request Dec 8, 2021
@jrodewig
[DOCS] Update snapshot defaults for system indices (#81226) (#81536)
2799af2 
Updates the snapshot and restore docs for #79670.

Closes #81183
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 8, 2021
@jrodewig @kibanamachine
Update snapshot docs for new system index defaults (elastic#120174)
0ee0b93 
With elastic/elasticsearch#79670, you can only include system indices in a snapshot using feature states. This updates some references to taking a snapshots of the `.kibana*` system indices.

Relates to elastic/elasticsearch#81226
kibanamachine added a commit to elastic/kibana that referenced this pull request Dec 8, 2021
@kibanamachine @jrodewig
Update snapshot docs for new system index defaults (#120174) (#120777)
38dc7e0 
With elastic/elasticsearch#79670, you can only include system indices in a snapshot using feature states. This updates some references to taking a snapshots of the `.kibana*` system indices.

Relates to elastic/elasticsearch#81226

Co-authored-by: James Rodewig <james.rodewig@elastic.co>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@jrodewig @TinLe
Update snapshot docs for new system index defaults (elastic#120174)
f62f6e8 
With elastic/elasticsearch#79670, you can only include system indices in a snapshot using feature states. This updates some references to taking a snapshots of the `.kibana*` system indices.

Relates to elastic/elasticsearch#81226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamrandolph williamrandolph williamrandolph approved these changes

@gwbrown gwbrown gwbrown approved these changes

@original-brownbear original-brownbear Awaiting requested review from original-brownbear

Assignees
No one assigned
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v8.0.0-beta1 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Update snapshot and restore docs for system index resolution changes
5 participants
@jrodewig @elasticmachine @gwbrown @williamrandolph @elasticsearchmachine