Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcontent filter: Add map and builder filter benchmark #81575

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Xcontent filter: Add map and builder filter benchmark #81575

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd3d41e
add benchmark
weizijun Dec 9, 2021
de22e6f
add benchmark
weizijun Dec 9, 2021
d01b3b7
add benchmark
weizijun Dec 9, 2021
717e2ca
add benchmark
weizijun Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 46 additions & 2 deletions benchmarks/src/main/java/org/elasticsearch/benchmark/xcontent/FilterContentBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@

package org.elasticsearch.benchmark.xcontent;

import org.elasticsearch.common.Strings;
import org.elasticsearch.common.bytes.BytesReference;
import org.elasticsearch.common.io.Streams;
import org.elasticsearch.common.io.stream.BytesStreamOutput;
import org.elasticsearch.common.util.Maps;
import org.elasticsearch.common.xcontent.XContentHelper;
import org.elasticsearch.common.xcontent.support.XContentMapValues;
import org.elasticsearch.search.fetch.subphase.FetchSourcePhase;
import org.elasticsearch.xcontent.XContentBuilder;
import org.elasticsearch.xcontent.XContentParser;
import org.elasticsearch.xcontent.XContentParserConfiguration;
Expand All @@ -39,8 +42,8 @@
import java.util.stream.Collectors;

@Fork(1)
@Warmup(iterations = 2)
@Measurement(iterations = 3)
@Warmup(iterations = 1)
@Measurement(iterations = 2)
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
@State(Scope.Benchmark)
Expand Down Expand Up @@ -122,6 +125,47 @@ public BytesReference filterWithNewParserConfig() throws IOException {
return filter(contentParserConfiguration);
}

@Benchmark
public BytesReference filterWithMap() throws IOException {
Map<String, Object> sourceMap = XContentHelper.convertToMap(source, false).v2();
String[] includes;
String[] excludes;
if (inclusive) {
includes = filters.toArray(Strings.EMPTY_ARRAY);
excludes = null;
} else {
includes = null;
excludes = filters.toArray(Strings.EMPTY_ARRAY);
}
Map<String, Object> filterMap = XContentMapValues.filter(sourceMap, includes, excludes);
return FetchSourcePhase.objectToBytes(filterMap, XContentType.JSON, Math.min(1024, source.length()));
}

@Benchmark
public BytesReference filterWithBuilder() throws IOException {
BytesStreamOutput streamOutput = new BytesStreamOutput(Math.min(1024, source.length()));
Set<String> includes;
Set<String> excludes;
if (inclusive) {
includes = filters;
excludes = Set.of();
} else {
includes = Set.of();
excludes = filters;
}
XContentBuilder builder = new XContentBuilder(
XContentType.JSON.xContent(),
streamOutput,
includes,
excludes,
XContentType.JSON.toParsedMediaType()
);
try (XContentParser parser = XContentType.JSON.xContent().createParser(XContentParserConfiguration.EMPTY, source.streamInput())) {
builder.copyCurrentStructure(parser);
return BytesReference.bytes(builder);
}
}

private XContentParserConfiguration buildParseConfig() {
Set<String> includes;
Set<String> excludes;
Expand Down