[Test] Fix superuser API key bwc test #82792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The role descriptors became optional since version 7.3.0. For earlier versions, they must be specified. This PR specifies them conditionally based on the old cluster version. This also serves a variation of the test to show that dropping write access to system indices from the limiting role will prevent the key from writing to system indices as a whole. Resolves: elastic#82785
ywangd
added
>test
|
Pinging @elastic/es-security (Team:Security) |
ywangd
changed the title
|
@elasticmachine run elasticsearch-ci/full-bwc |
|
@elasticmachine run elasticsearch-ci/part-2-fips |
jkakavas
approved these changes
Jan 21, 2022
| + "version, direct access to system indices will be prevented by default" | ||
| ).toBuilder().addHeader("Authorization", apiKeyAuthHeader) | ||
| ); | ||
| // Configure the warning to be optional due to #82837, it is ok since this test is for something else |
There was a problem hiding this comment.
maybe add a TODO to change this back or as part of the fix for #82837 ? This comment can be enough on its own though :)
There was a problem hiding this comment.
Good point. I added a TODO. Thanks!
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Jan 24, 2022
The role descriptors became optional since version 7.3.0. For earlier versions, they must be specified. This PR specifies them conditionally based on the old cluster version. This also serves a variation of the test to show that dropping write access to system indices from the limiting role will prevent the key from writing to system indices as a whole. Resolves: elastic#82785
💚 Backport successful
|
ywangd
added a commit
that referenced
this pull request
Jan 24, 2022
The role descriptors became optional since version 7.3.0. For earlier versions, they must be specified. This PR specifies them conditionally based on the old cluster version. This also serves a variation of the test to show that dropping write access to system indices from the limiting role will prevent the key from writing to system indices as a whole. Backport: #82792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following BWC issues:
Resolves: #82785