Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interface for transport client #83486

Merged
merged 5 commits into from
Feb 28, 2022

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Feb 3, 2022

This removes the Max interface that was important for the transport
client and renames InternalMax to Max. The transport client isn't a
think any more so we don't need to keep these interfaces around any
more.

Related to #82273

@nik9000 nik9000 requested a review from not-napoleon February 3, 2022 22:09
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 3, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

This removes the `Max` interface that was important for the transport
client and renames `InternalMax` to `Max`. The transport client isn't a
think any more so we don't need to keep these interfaces around any
more.

Related to elastic#82273
Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000
Copy link
Member Author

nik9000 commented Feb 28, 2022

@elasticmachine update branch

@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Feb 28, 2022
@elasticsearchmachine elasticsearchmachine merged commit 8cbcace into elastic:master Feb 28, 2022
@nik9000 nik9000 deleted the iface_max branch February 28, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants