Increment version on system index settings change #84994
Conversation
The test was failing on assertion around index settings version change in case actual settings were changed. This change adds missing version increment and readable messages to the related assertions.
idegtiarenko
added
>test-failure
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
I think this should be backported to 8.1 too, because the change that caused so many build failures that led to this fix (#84780) was backported to 8.1. The other thing is whether this should be considered a blocker for 8.1.1. That is due to be built today, but if it ships without this fix then production clusters will end up going through the code branch with a failing assertion. They won't trip the assertion as production clusters have assertions disabled, but is it still a major problem that the settings version is wrong? If so then 8.1.1 should be delayed until this fix is in the 8.1 branch. |
Yes, that fix is merged into 8.1 as well. Let me open a back-port shortly |
|
I am trying to find exact commit/version where the issue was introduced, but I suspect it was prior 8.1. I believe #84780 is not an actual cause, just a change that un-muted the test that discovered the issue. |
|
Looks like this behavior was originally introduced in #72768 (7.13.1, 7.14.0) and then updated in #79512 (8.0.0-rc, 8.1.0). @droberts195 should I also back-port it to 7.17? I am not sure how significant this issue is and if this should become a blocker. |
The test was failing on assertion around index settings version change in case actual settings were changed. This change adds missing version increment and readable messages to the related assertions. (cherry picked from commit 351a410)
OK, fair enough, I guess it's not a blocker then. |
The test was failing on assertion around index settings version change in case actual settings were changed. This change adds missing version increment and readable messages to the related assertions. (cherry picked from commit 351a410)
The test was failing on assertion around index settings version change in case actual settings were changed. This change adds missing version increment and readable messages to the related assertions. (cherry picked from commit 351a410)
The test was failing on assertion around index settings version change in case actual settings were changed. This change adds missing version increment and readable messages to the related assertions. (cherry picked from commit 351a410)
The test was failing on assertion around index settings version change
in case actual settings were changed. This change adds missing version
increment and readable messages to the related assertions.
Closes: #84869