Remove timestampField from DataStreamTestHelper#newInstance(...) helper methods #85260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er methods. This makes tests a bit cleaner. The timestamp field is always '@timestamp' and in the future will likely remove the 'timeStampField' field from `DataStream` class. Since in practice it is always '@timestamp'. When data streams was developed the idea was the timestamp field would be configurable. We left it hardcode to '@timestamp', since that is the timestamp field for all Elastic solutions. In the last years we have not found a reason to use any other timestamp field than '@timestamp', so in the future will likely remove this 'timeStampField' field from `DataStream` class, which currently is hardcoded to '@timestamp'.
martijnvg
added
>non-issue
:Data Management/Data streams
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
joegallo
approved these changes
Mar 23, 2022
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 24, 2022
Timestamp field is always '@timestamp' and is already fixed to this field. Removing this parameter from DataStream's constructors makes this clearer and makes the code a bit cleaner too. This change doesn't break bwc in any way or change the xcontent/binary format. A next followup change may do this. Followup from elastic#85260
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 28, 2022
Timestamp field is always '@timestamp' and is already fixed to this field. Removing this parameter from DataStream's constructors makes this clearer and makes the code a bit cleaner too. This change doesn't break bwc in any way or change the xcontent/binary format. A next followup change may do this. Followup from #85260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes tests a bit cleaner.
The timestamp field is always
@timestampand in the future will likelyremove the 'timeStampField' field from
DataStreamclass. Since in practiceit is always
@timestamp.When data streams was developed the idea was the timestamp field would be configurable.
We left it hardcode to '@timestamp', since that is the timestamp field for all Elastic
solutions. In the last years we have not found a reason to use any other timestamp field
than
@timestampso in the future will likely remove this 'timeStampField' field fromDataStreamclass, which currently is hardcoded to@timestamp.