remove suggest flag

[anmironov]

we have a parameter suggest, it is removed since 7.0.0 #29635. But I am unsure

• Have you signed the contributor license agreement?
• Have you followed the contributor guidelines?
• If submitting code, have you built your formula locally prior to submission with gradle check?
• If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
• If submitting code, have you checked that your submission is for an OS and architecture that we support?
• If you are submitting this code for a class then read our policy for that.

[elasticsearchmachine]

@anmironov please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

[elasticmachine]

Pinging @elastic/es-data-management (Team:Data Management)

[elasticmachine]

Pinging @elastic/es-docs (Team:Docs)

[joegallo]

Okay, tracing this through backwards and writing up my thought process:

1. suggest where you've removed it is part of the index-metrics tag.
2. And that's only used in one place, the indices stats page:

   joegallo@galactic:~/Code/elastic/elasticsearch $ git grep 'index-metric'
   docs/reference/indices/stats.asciidoc:`GET /<target>/_stats/<index-metric>`
   docs/reference/indices/stats.asciidoc:include::{es-repo-dir}/rest-api/common-parms.asciidoc[tag=index-metric]
   

3. Which is https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-stats.html, or GET /{someindex}/_stats
4. Testing GET /myindex/_stats/suggest does indeed result in an error, because we removed that in Remove the suggest metric from stats APIs #29635, as you correctly indicated.

So, yeah, +1, that makes sense to me.

While I was there, I noticed a couple of other things that were off, too, and I'll bring those up with the relevant stakeholders and see to fixing them. Thanks for bringing this to our attention and submitting a pull request!