-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security - kibana_system - add delete privileges for synthetics #85844
Security - kibana_system - add delete privileges for synthetics #85844
Conversation
Pinging @elastic/es-security (Team:Security) |
ping @elastic/kibana-security |
@@ -777,7 +777,13 @@ public static RoleDescriptor kibanaSystemRoleDescriptor(String name) { | |||
"metrics-apm-*", | |||
"metrics-apm.*-*", | |||
"traces-apm-*", | |||
"traces-apm.*-*" | |||
"traces-apm.*-*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it'd make sense to mention Synthetics
in the comment above.
"synthetics-http-*", | ||
"synthetics-icmp-*", | ||
"synthetics-tcp-*", | ||
"synthetics-browser-*", | ||
"synthetics-browser.network-*", | ||
"synthetics-browser.screenshot-*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: do we document these patterns anywhere like we do for APM patterns (dataset
part in particular, http/icmp/tcp/browser/browser.network/browser.screenshot
)? I wanted to make sure there are no typos in the names and so on, but couldn't quickly find any references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately no, we do have this docs ticket where we will address in the future elastic/synthetics#286
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this matches the needs of the new ILM policies added in elastic/integrations#2744
@azasypkin @joshdover I'm not a ES contributor, so I'm hoping one of you can tell me what Also, I have not updated this branch in a week. Do I need to merge upstream similar to Kibana? |
@elasticmachine update branch |
@dominiqueclarke The above "update branch" should most likely fixes the CI failure. |
Resolves elastic/uptime#467
As part of elastic/uptime#462, Uptime will introduce default ILM policies with default delete phases for the
synthetics-http
,synthetics-tcp
,synthetics-icmp
,synthetics-brower
,synthetics-browser.network
andsynthetics-browser.screenshot
data sets.To support this work, the Kibana system user must have extended privileges to delete data streams associated with these data sets.