Make sure to rewrite explain query on coordinator #87013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>bug
:Search/Search
|
Hi @jtibshirani, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search (Team:Search) |
|
Thanks for the review! |
jtibshirani
added a commit
that referenced
this pull request
May 24, 2022
Some queries (like terms lookup queries) need to be rewritten on the coordinator node, usually to fetch some resource. The explain action was missing this rewrite step, which caused failures later when trying to execute the query. Closes #64281.
jtibshirani
added a commit
that referenced
this pull request
May 24, 2022
Some queries (like terms lookup queries) need to be rewritten on the coordinator node, usually to fetch some resource. The explain action was missing this rewrite step, which caused failures later when trying to execute the query. Closes #64281.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some queries (like terms lookup queries) need to be rewritten on the
coordinator node, usually to fetch some resource. The explain action was
missing this rewrite step, which caused failures later when trying to execute
the query.
This PR applies a similar fix to #29033 and rewrites the query in
TransportExplainAction.Closes #64281.