Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IndicesPermission authorize method #88662

Merged
merged 9 commits into from
Jul 27, 2022
Merged

Refactor IndicesPermission authorize method #88662

merged 9 commits into from
Jul 27, 2022

Conversation

slobodanadamovic
Copy link
Contributor

@slobodanadamovic slobodanadamovic commented Jul 20, 2022 •
edited
Loading

Separated authorization check from computation of index access control.
The change is simply a preparation for allowing the access control to be computed lazily.

@slobodanadamovic
Refactor IndicesPermission authorize method
e4b20ee 
This commit is separating authorization check from computation of
index access control. The change is simply a preparation for allowing
the access control to be computed lazily.
@slobodanadamovic slobodanadamovic added >non-issue :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team labels Jul 20, 2022
@slobodanadamovic slobodanadamovic self-assigned this Jul 20, 2022
@slobodanadamovic slobodanadamovic marked this pull request as ready for review July 21, 2022 07:12
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@slobodanadamovic slobodanadamovic mentioned this pull request Jul 22, 2022
Merged
albertzaharovits
albertzaharovits approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the shortcircuit suggestion, otherwise it's good to merge.

@albertzaharovits
Copy link
Contributor

@slobodanadamovic ,actually, please do not merge until the 8.4 branch is been cut (next Tuesday) because this change by itself is actually less performant because the permission groups are checked multiple times (once in the authz and then in the accesss control).

@elasticsearchmachine elasticsearchmachine changed the base branch from master to main July 22, 2022 23:04
albertzaharovits
albertzaharovits approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-vieira mark-vieira added v8.5.0 and removed v8.4.0 labels Jul 27, 2022
@slobodanadamovic slobodanadamovic merged commit 04635b5 into elastic:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertzaharovits albertzaharovits albertzaharovits approved these changes

Assignees

@slobodanadamovic slobodanadamovic

Labels
>non-issue :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slobodanadamovic @elasticsearchmachine @albertzaharovits @mark-vieira