Reduce memory required for search responses when many shards are unavailable #91365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>bug
:Search/Search
|
Hi @benwtrent, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
…-shards-unavailable
…vailable' of github.com:benwtrent/elasticsearch into feature/search-improve-performance-when-many-shards-unavailable
…ove-performance-when-many-shards-unavailable
|
Pinging @elastic/es-search (Team:Search) |
benwtrent
commented
Dec 16, 2022
server/src/main/java/org/elasticsearch/ElasticsearchException.java
Outdated
Show resolved
Hide resolved
…ove-performance-when-many-shards-unavailable
javanna
reviewed
Dec 21, 2022
server/src/main/java/org/elasticsearch/action/NoShardAvailableActionException.java
Outdated
Show resolved
Hide resolved
javanna
reviewed
Dec 21, 2022
server/src/main/java/org/elasticsearch/action/NoShardAvailableActionException.java
Outdated
Show resolved
Hide resolved
|
run elasticsearch-ci/docs |
|
@elasticmachine update branch |
…-shards-unavailable
javanna
reviewed
Jan 11, 2023
…ove-performance-when-many-shards-unavailable
|
I would propose backporting this to 8.6, I added the relevant label. |
|
@elasticmachine update branch |
…-shards-unavailable
|
run elasticsearch-ci/bwc |
benwtrent
deleted the
feature/search-improve-performance-when-many-shards-unavailable
branch
💚 Backport successful
|
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jan 13, 2023
…ailable (elastic#91365) When there are many shards unavailable, we repeatably store the exact same stack trace and exception. The only difference is the exception message. This commit fixes this by slightly modifying the created exception to not provide a stacktrace or print its stacktrace as a "reason" when a shard is unavailable. closes elastic#90622
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 13, 2023
…ailable (#91365) (#92907) When there are many shards unavailable, we repeatably store the exact same stack trace and exception. The only difference is the exception message. This commit fixes this by slightly modifying the created exception to not provide a stacktrace or print its stacktrace as a "reason" when a shard is unavailable. closes #90622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are many shards unavailable, we repeatably store the exact same stack trace and exception. The only difference is the exception message.
This commit fixes this by slightly modifying the created exception to not provide a stacktrace or print its stacktrace as a "reason" when a shard is unavailable.
closes #90622