Remove rolling restart checks for x-pack #95428
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the checks introduced in #30743.
Those checks were to help enable rolling restarts from the
OSS distribution to the (now) default distribution that includes
x-pack by default. These checks are no longer needed since
we no longer ship an OSS version #68797
that is the base (lowest) version during a rolling restart.
Any rolling restart to 8.x requires 7.17+ but the last official
OSS distribution that did not include x-pack was 7.11. This
change, when applied to 8.x, means that all supported rolling
restarts to 8.x will already have x-pack metadata and thus no
need for these checks.
Note - the node attribute remains to handle and edge case
for a new mixed cluster where there is elder 8.x (i.e. 8.6) node
that has the node attibute set to true. In that case, the value of
the attribute will always be true but removing the
attribute could cause an error.
This PR replaces #93843 since there were too many merge conflicts to sort it out there and didn't want to force push and risk loosing the comments in that PR.