Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeSeriesIndexSearcher to offload to the provided executor #98414

Merged

Conversation

javanna
Copy link
Member

@javanna javanna commented Aug 11, 2023

We have introduced a search worker thread pool with #98204 that is responsible for the heavy workloads as part of the query and dfs phase, no matter if it is parallelized across segments/slices or not. TSDB aggregations are still executed in the search thread pool and this commit moves their computation to the search worker thread pool, despite the corresponding search thread blocks and waits for such computation to be completed before returning.

We have introduced a search worker thread pool with elastic#98204 that is
responsible for the heavy workloads as part of the query and dfs phase,
no matter if it is parallelized across segments/slices or not. TSDB
aggregations are still executed in the search thread pool and this
commit moves their computation to the search worker thread pool, despite
the corresponding search thread blocks and  waits for such computation to be
completed before returning.
@javanna javanna requested a review from martijnvg August 11, 2023 19:19
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 11, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @javanna, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@javanna
Copy link
Member Author

javanna commented Aug 11, 2023

run elasticsearch-ci/part-1

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javanna javanna merged commit ae792cd into elastic:main Aug 14, 2023
@javanna javanna deleted the enhancement/offload_time_series_searcher branch August 14, 2023 18:06
@javanna
Copy link
Member Author

javanna commented Aug 14, 2023

Thanks @martijnvg !

csoulios pushed a commit to csoulios/elasticsearch that referenced this pull request Aug 18, 2023
…98414)

We have introduced a search worker thread pool with elastic#98204 that is
responsible for the heavy workloads as part of the query and dfs phase,
no matter if it is parallelized across segments/slices or not. TSDB
aggregations are still executed in the search thread pool and this
commit moves their computation to the search worker thread pool, despite
the corresponding search thread blocks and  waits for such computation to be
completed before returning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants