Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Transform schema v2 (#270)" (#411)" #418

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Revert "Revert "Transform schema v2 (#270)" (#411)" #418

merged 2 commits into from
Oct 30, 2023

Conversation

pzl
Copy link
Member

@pzl pzl commented Aug 16, 2023

Change Summary

This reverts commit 584f50a.

Since transforms v2 & unattended were pulled from 8.10, and ESQL will not be a ready substitute until ~8.12 or so, add this back into 8.11 and fix install

Sample values

N/A
Sample document:

N/A

Release Target

8.11

Q/A

For Transform changes:

  • The new transform successfully starts in Kibana
  • The corresponding transform destination schema was updated if necessary

The package will successfully run and install in this state, but a companion Kibana PR is needed to update test references to the new transform name

@pzl pzl requested a review from a team as a code owner August 16, 2023 19:59
@pzl pzl requested review from kevinlog and joeypoon and removed request for paul-tavares August 16, 2023 20:05
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 16, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-30T14:37:27.498+0000

  • Duration: 7 min 0 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@pzl pzl merged commit 7e59c92 into main Oct 30, 2023
6 of 8 checks passed
@pzl pzl deleted the tf-v2-again branch October 30, 2023 14:46
pzl added a commit that referenced this pull request Dec 12, 2023
@pzl
Revert v3 compliance work
34c30f1 
Revert "Revert "Revert "Transform schema v2 (#270)" (#411)" (#418)"

This reverts commit 7e59c92
This reverts commit cf54cde
This reverts commit 0d1065c
@pzl pzl mentioned this pull request Dec 12, 2023
Merged
4 tasks
pzl added a commit that referenced this pull request Dec 12, 2023
@pzl
Revert "Revert "Revert "Transform schema v2 (#270)" (#411)" (#418)" (#…
c515860 
…461)

* Revert v3 compliance work

This reverts commit 7e59c92
This reverts commit cf54cde
This reverts commit 0d1065c
pzl added a commit that referenced this pull request Apr 2, 2024
@pzl
Revert "Revert "Transform schema v2 (#270)" (#411)" (#418)
1facf4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeypoon joeypoon joeypoon approved these changes

@parkiino parkiino Awaiting requested review from parkiino parkiino is a code owner automatically assigned from elastic/security-defend-workflows

@kevinlog kevinlog Awaiting requested review from kevinlog

Assignees
No one assigned
Labels
8.11-candidate transform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pzl @elasticmachine @joeypoon