-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memory_region to api events #445
Conversation
a31a6bb
to
0252281
Compare
🤔 Why do the generated files from my build have different whitespace to the existing files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM but red build.
The five The failures look like the same |
I'm not going to block a merge over this, but could you follow up with a PR that adds the new fields to the sample API event so their inclusion in enforced by |
That's a credential_access API event sample - which I didn't want to overwrite. |
They don't have to be real events with real meaning. The point is just to exercise the schema validation code. |
Should this be targeting 8.11 or main? Would we really release an updated endpoint package for 8.11? |
@jdu2600 the data's already there but not in the mapping, right? If so, that's arguably a bug. |
Echoing @gabriellandau, I would love to see values for these fields added to the sample file. The Buildkite migration is blocked, so it's in purgatory still, will be red until a dependency is fixed. It can be safely ignored. The rest of the statuses are green. It seems like this is entirely additions, so backporting is not out of the question for 8.11. Just ping the defend workflows team if we need to cut a release |
Updated the sample file (including fields added in #427). |
we should merge this to |
18d6ea1
to
62df8f5
Compare
I've re-targeted this PR to |
* add memory_region to api * add parameter variants * add memory_region to sample API event * add generated file * force api.yaml to regenerate
Package endpoint - 8.12.0 containing this change is available at https://epr.elastic.co/search?package=endpoint |
Add missing
[Target.]process.Ext.memory_region
fields to api events.These optional fields were introduced in 8.11.0