Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add process.Ext.protection to Windows library events #528

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Add process.Ext.protection to Windows library events #528

merged 3 commits into from
Aug 22, 2024

Conversation

jdu2600
Copy link
Contributor

@jdu2600 jdu2600 commented Aug 22, 2024 •
edited
Loading

Change Summary

Add process.Ext.protection to Windows library events - added in 8.15.1.

For mapping changes:

  • I ran make after making the schema changes, and committed all changes
  • If these field(s) are "exception"-able, I made a companion PR to Kibana adding it (see Readme)
  • If this is a metadata change, I also updated both transform destination schemas to match

@jdu2600 jdu2600 self-assigned this Aug 22, 2024
@jdu2600 jdu2600 requested review from a team as code owners August 22, 2024 08:16
@ashokaditya ashokaditya requested a review from pzl August 22, 2024 13:45
pzl
pzl reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a sample value to package/endpoint/data_stream/library/sample_event.json?

This will ship with integration version 8.16. Is there a need for deploying this for 8.15 stacks?

@jdu2600
Copy link
Contributor Author

jdu2600 commented Aug 22, 2024

Done.
And added to package/endpoint/data_stream/process/sample_event.json also.

@gabriellandau gabriellandau merged commit 445b9f1 into main Aug 22, 2024
4 checks passed
@gabriellandau gabriellandau deleted the custom_documentation-windows_library_load branch August 22, 2024 15:24
pzl pushed a commit that referenced this pull request Aug 22, 2024
@jdu2600 @pzl
Add process.Ext.protection to Windows library events (#528)
79db083 
* add process.Ext.protection to library event

* add generated files

* update sample events
@pzl pzl mentioned this pull request Aug 22, 2024
Merged
pzl added a commit that referenced this pull request Aug 22, 2024
@pzl @jdu2600
Add process.Ext.protection to Windows library events (#528) (#529)
2ecccc3 
Co-authored-by: John U <53329154+jdu2600@users.noreply.github.com>
@elasticmachine
Copy link
Contributor

Package endpoint - 8.15.1 containing this change is available at https://epr.elastic.co/search?package=endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzl pzl pzl approved these changes

@gabriellandau gabriellandau gabriellandau approved these changes

@nfritts nfritts nfritts approved these changes

@joeypoon joeypoon Awaiting requested review from joeypoon joeypoon is a code owner automatically assigned from elastic/security-defend-workflows

@paul-tavares paul-tavares Awaiting requested review from paul-tavares paul-tavares is a code owner automatically assigned from elastic/security-defend-workflows

Assignees

@jdu2600 jdu2600

Labels
v8.15.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdu2600 @elasticmachine @pzl @gabriellandau @nfritts