[EuiSelectableList[Item]] Fix showIcons prop (#4920)

elastic · Jun 24, 2021 · 0d9a270 · 0d9a270
1 parent 9ccc0c4
commit 0d9a270
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 ## [`master`](https://github.com/elastic/eui/tree/master)
 
-No public interface changes since `34.5.0`.
+**Bug fixes**
+
+- Fixed `showIcons` prop in `EuiSelectableListItem` ([#4920](https://github.com/elastic/eui/pull/4920))
 
 ## [`34.5.0`](https://github.com/elastic/eui/tree/v34.5.0)
 

diff --git a/src-docs/src/views/selectable/selectable_custom_render.js b/src-docs/src/views/selectable/selectable_custom_render.js
@@ -19,6 +19,7 @@ export default () => {
       searchableLabel: `${country.name} ${'I am secondary content, I am!'}`,
       prepend: country.flag,
       append: <EuiBadge>{country.code}</EuiBadge>,
+      showIcons: false,
     };
   });
 

diff --git a/src/components/selectable/selectable_list/selectable_list.tsx b/src/components/selectable/selectable_list/selectable_list.tsx
@@ -247,9 +247,8 @@ export class EuiSelectableList<T> extends Component<EuiSelectableListProps<T>> {
         aria-setsize={data.length - labelCount}
         onFocusBadge={this.props.onFocusBadge}
         allowExclusions={this.props.allowExclusions}
-        // @ts-ignore complex
-        {...(optionRest as EuiSelectableListItemProps)}
-        showIcons={this.props.showIcons}>
+        showIcons={this.props.showIcons}
+        {...(optionRest as EuiSelectableListItemProps)}>
         {this.props.renderOption ? (
           this.props.renderOption(option, this.props.searchValue)
         ) : (

diff --git a/src/components/selectable/selectable_list/selectable_list_item.tsx b/src/components/selectable/selectable_list/selectable_list_item.tsx
@@ -47,7 +47,7 @@ export type EuiSelectableListItemProps = LiHTMLAttributes<HTMLLIElement> &
     /**
      * Shows icons based on `checked` type
      */
-    showIcons: boolean;
+    showIcons?: boolean;
     /**
      * Highlights the item for pseudo focus
      */