[PR feedback] Simplify fns/useEffects

src/components/datagrid/body/header/data_grid_header_cell_wrapper.tsx

@@ -49,26 +49,17 @@ export const EuiDataGridHeaderCellWrapper: FunctionComponent<
   }, [index, setFocusedCell]);
 
   const [isFocused, setIsFocused] = useState(false);
-
-  const updateFocus = (isFocused: Boolean, headerEl: HTMLDivElement | null) => {
-    if (isFocused && headerEl) {
-      // Only focus the cell if not already focused on something in the cell
-      if (!headerEl.contains(document.activeElement)) {
-        headerEl.focus();
-      }
-    }
-  }
-
   useEffect(() => {
     onFocusUpdate([index, -1], (isFocused: boolean) => {
       setIsFocused(isFocused);
-      updateFocus(isFocused, headerEl);
+      if (isFocused && headerEl) {
+        // Only focus the cell if not already focused on something in the cell
+        if (!headerEl.contains(document.activeElement)) {
+          headerEl.focus();
+        }
+      }
     });
-  }, [index, onFocusUpdate]);
-
-  useEffect(() => {
-    updateFocus(isFocused, headerEl);
-  }, [headerEl]);
+  }, [index, onFocusUpdate, headerEl]);
 
   // For cell headers with actions, auto-focus into the button instead of the cell wrapper div
   // The button text is significantly more useful to screen readers (e.g. contains sort order & hints)