Skip to content

Commit

Permalink
[EuiNavDrawer] Fix scrolling in mobile view (#3174)
Browse files Browse the repository at this point in the history
  • Loading branch information
lokeshrana9999 authored Mar 27, 2020
1 parent fae74c0 commit 1bc6b4a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
- Fixed `EuiSearchBar` related types ([#3147](https://github.com/elastic/eui/pull/3147))
- Added `prepend` and `append` ability to `EuiSuperSelect` ([#3167](https://github.com/elastic/eui/pull/3167))

**Bug Fixes**

- Fixed `EuiNavDrawer` scrolling issue on mobile ([#3174](https://github.com/elastic/eui/pull/3174))

## [`22.0.0`](https://github.com/elastic/eui/tree/v22.0.0)

- Replaced various `lodash` functions with native functions ([#3053](https://github.com/elastic/eui/pull/3053))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ exports[`EuiNavDrawer is rendered 1`] = `
class="euiNavDrawer euiNavDrawer-isCollapsed euiNavDrawer-flyoutIsCollapsed"
>
<div
class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive"
class="euiFlexGroup euiFlexGroup--directionRow"
>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
Expand Down Expand Up @@ -266,7 +266,7 @@ exports[`EuiNavDrawer renders with falsy children 1`] = `
class="euiNavDrawer euiNavDrawer-isCollapsed euiNavDrawer-flyoutIsCollapsed"
>
<div
class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive"
class="euiFlexGroup euiFlexGroup--directionRow"
>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
Expand Down Expand Up @@ -473,7 +473,7 @@ exports[`EuiNavDrawer renders with fragments 1`] = `
class="euiNavDrawer euiNavDrawer-isCollapsed euiNavDrawer-flyoutIsCollapsed"
>
<div
class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive"
class="euiFlexGroup euiFlexGroup--directionRow"
>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
Expand Down
2 changes: 1 addition & 1 deletion src/components/nav_drawer/nav_drawer.js
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ export class EuiNavDrawer extends Component {
onOutsideClick={() => this.closeBoth()}
isDisabled={this.state.outsideClickDisabled}>
<nav className={classes} {...rest}>
<EuiFlexGroup gutterSize="none">
<EuiFlexGroup gutterSize="none" responsive={false}>
<EuiFlexItem grow={false}>
<div
id={MENU_ELEMENT_ID}
Expand Down

0 comments on commit 1bc6b4a

Please sign in to comment.