Skip to content

Commit

Permalink
Extended types for ReactDatePicker's startDate and endDate to allow n…
Browse files Browse the repository at this point in the history
…ull (#3343)

* Extended types for ReactDatePicker's startDate and endDate to allow null

* changelog
  • Loading branch information
chandlerprall authored Apr 21, 2020
1 parent 85e6a76 commit 4b3f9e9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Added `showCloseButton` and `dockedBreakpoint` flexibility to `EuiCollapsibleNav` ([#3330](https://github.com/elastic/eui/pull/3330))
- Added `panelStyle` prop to `EuiPopover` to distinguish style object configuration ([#3329](https://github.com/elastic/eui/pull/3329))
- Extended `EuiDatePicker`'s `startDate` and `endDate` types to accept `null` values for better interoperability ([#3343](https://github.com/elastic/eui/pull/3343))

**Bug Fixes**

Expand Down
4 changes: 2 additions & 2 deletions src/components/date_picker/react-datepicker.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export interface ReactDatePickerProps {
disabled?: boolean;
disabledKeyboardNavigation?: boolean;
dropdownMode?: 'scroll' | 'select';
endDate?: moment.Moment;
endDate?: moment.Moment | null;
excludeDates?: moment.Moment[];
excludeTimes?: moment.Moment[];
filterDate?(date: moment.Moment): boolean;
Expand Down Expand Up @@ -177,7 +177,7 @@ export interface ReactDatePickerProps {
showTimeSelectOnly?: boolean;
showWeekNumbers?: boolean;
showYearDropdown?: boolean;
startDate?: moment.Moment;
startDate?: moment.Moment | null;
startOpen?: boolean;
tabIndex?: number;
timeCaption?: string;
Expand Down

0 comments on commit 4b3f9e9

Please sign in to comment.