remove menubar role from EuiSideNav (#2429)

* remove menubar role from EuiSideNav
elastic · Oct 16, 2019 · 5f1a4be · 5f1a4be
1 parent 307e640
commit 5f1a4be
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 44 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 **Bug fixes**
 
 - Fixed missing misc. button and link type definition exports ([#2434](https://github.com/elastic/eui/pull/2434))
+- Strip custom semantics from `EuiSideNav` ([#2429](https://github.com/elastic/eui/pull/2429))
 
 ## [`14.5.0`](https://github.com/elastic/eui/tree/v14.5.0)
 

diff --git a/src/components/side_nav/__snapshots__/side_nav.test.js.snap b/src/components/side_nav/__snapshots__/side_nav.test.js.snap
@@ -29,7 +29,6 @@ exports[`EuiSideNav is rendered 1`] = `
   </button>
   <div
     class="euiSideNav__content"
-    role="menubar"
   />
 </nav>
 `;
@@ -61,7 +60,6 @@ exports[`EuiSideNav props isOpenOnMobile defaults to false 1`] = `
   </button>
   <div
     class="euiSideNav__content"
-    role="menubar"
   />
 </nav>
 `;
@@ -93,7 +91,6 @@ exports[`EuiSideNav props isOpenOnMobile is rendered when specified as true 1`]
   </button>
   <div
     class="euiSideNav__content"
-    role="menubar"
   />
 </nav>
 `;
@@ -125,13 +122,11 @@ exports[`EuiSideNav props items is rendered 1`] = `
   </button>
   <div
     class="euiSideNav__content"
-    role="menubar"
   >
     <div
       class="euiSideNavItem euiSideNavItem--root euiSideNavItem--hasChildItems"
     >
       <div
-        aria-label="[object Object]"
         class="euiSideNavItemButton"
       >
         <span
@@ -151,7 +146,6 @@ exports[`EuiSideNav props items is rendered 1`] = `
           class="euiSideNavItem euiSideNavItem--trunk"
         >
           <div
-            aria-label="[object Object]"
             class="euiSideNavItemButton"
           >
             <span
@@ -169,7 +163,6 @@ exports[`EuiSideNav props items is rendered 1`] = `
           class="euiSideNavItem euiSideNavItem--trunk"
         >
           <div
-            aria-label="[object Object]"
             class="euiSideNavItemButton"
           >
             <span
@@ -224,13 +217,11 @@ exports[`EuiSideNav props items renders items having { forceOpen: true } in open
   </button>
   <div
     class="euiSideNav__content"
-    role="menubar"
   >
     <div
       class="euiSideNavItem euiSideNavItem--root euiSideNavItem--hasChildItems"
     >
       <div
-        aria-label="[object Object]"
         class="euiSideNavItemButton"
       >
         <span
@@ -250,7 +241,6 @@ exports[`EuiSideNav props items renders items having { forceOpen: true } in open
           class="euiSideNavItem euiSideNavItem--trunk"
         >
           <div
-            aria-label="[object Object]"
             class="euiSideNavItemButton"
           >
             <span
@@ -268,7 +258,6 @@ exports[`EuiSideNav props items renders items having { forceOpen: true } in open
           class="euiSideNavItem euiSideNavItem--trunk euiSideNavItem--hasChildItems"
         >
           <div
-            aria-label="[object Object]"
             class="euiSideNavItemButton euiSideNavItemButton-isOpen"
           >
             <span
@@ -288,7 +277,6 @@ exports[`EuiSideNav props items renders items having { forceOpen: true } in open
               class="euiSideNavItem euiSideNavItem--branch euiSideNavItem--hasChildItems"
             >
               <div
-                aria-label="[object Object]"
                 class="euiSideNavItemButton euiSideNavItemButton-isOpen"
               >
                 <span
@@ -308,7 +296,6 @@ exports[`EuiSideNav props items renders items having { forceOpen: true } in open
                   class="euiSideNavItem euiSideNavItem--branch"
                 >
                   <div
-                    aria-label="[object Object]"
                     class="euiSideNavItemButton"
                   >
                     <span
@@ -359,7 +346,6 @@ exports[`EuiSideNav props items renders items using a specified callback 1`] = `
   </button>
   <div
     class="euiSideNav__content"
-    role="menubar"
   >
     <div
       class="euiSideNavItem euiSideNavItem--root euiSideNavItem--hasChildItems"
@@ -433,15 +419,13 @@ exports[`EuiSideNav props items renders items which are links 1`] = `
   </button>
   <div
     class="euiSideNav__content"
-    role="menubar"
   >
     <div
       class="euiSideNavItem euiSideNavItem--root euiSideNavItem--hasChildItems"
     >
       <a
         class="euiSideNavItemButton euiSideNavItemButton--isClickable"
         href="http://www.elastic.co"
-        role="menuitem"
       >
         <span
           class="euiSideNavItemButton__content"
@@ -460,7 +444,6 @@ exports[`EuiSideNav props items renders items which are links 1`] = `
           class="euiSideNavItem euiSideNavItem--trunk"
         >
           <div
-            aria-label="[object Object]"
             class="euiSideNavItemButton"
           >
             <span
@@ -478,7 +461,6 @@ exports[`EuiSideNav props items renders items which are links 1`] = `
           class="euiSideNavItem euiSideNavItem--trunk"
         >
           <div
-            aria-label="[object Object]"
             class="euiSideNavItemButton"
           >
             <span
@@ -533,13 +515,11 @@ exports[`EuiSideNav props items renders selected item and automatically opens pa
   </button>
   <div
     class="euiSideNav__content"
-    role="menubar"
   >
     <div
       class="euiSideNavItem euiSideNavItem--root euiSideNavItem--hasChildItems"
     >
       <div
-        aria-label="[object Object]"
         class="euiSideNavItemButton"
       >
         <span
@@ -559,7 +539,6 @@ exports[`EuiSideNav props items renders selected item and automatically opens pa
           class="euiSideNavItem euiSideNavItem--trunk"
         >
           <div
-            aria-label="[object Object]"
             class="euiSideNavItemButton"
           >
             <span
@@ -577,7 +556,6 @@ exports[`EuiSideNav props items renders selected item and automatically opens pa
           class="euiSideNavItem euiSideNavItem--trunk euiSideNavItem--hasChildItems"
         >
           <div
-            aria-label="[object Object]"
             class="euiSideNavItemButton euiSideNavItemButton-isOpen"
           >
             <span
@@ -597,7 +575,6 @@ exports[`EuiSideNav props items renders selected item and automatically opens pa
               class="euiSideNavItem euiSideNavItem--branch"
             >
               <div
-                aria-label="[object Object]"
                 class="euiSideNavItemButton euiSideNavItemButton-isSelected"
               >
                 <span
@@ -615,7 +592,6 @@ exports[`EuiSideNav props items renders selected item and automatically opens pa
               class="euiSideNavItem euiSideNavItem--branch"
             >
               <div
-                aria-label="[object Object]"
                 class="euiSideNavItemButton"
               >
                 <span

diff --git a/src/components/side_nav/__snapshots__/side_nav_item.test.js.snap b/src/components/side_nav/__snapshots__/side_nav_item.test.js.snap
@@ -5,7 +5,6 @@ exports[`EuiSideNavItem is rendered 1`] = `
   class="euiSideNavItem"
 >
   <div
-    aria-label="[object Object]"
     class="euiSideNavItemButton"
   >
     <span
@@ -30,7 +29,6 @@ exports[`EuiSideNavItem isSelected defaults to false 1`] = `
   class="euiSideNavItem"
 >
   <div
-    aria-label="[object Object]"
     class="euiSideNavItemButton"
   >
     <span
@@ -51,7 +49,6 @@ exports[`EuiSideNavItem isSelected is rendered when specified as true 1`] = `
   class="euiSideNavItem"
 >
   <div
-    aria-label="[object Object]"
     class="euiSideNavItemButton euiSideNavItemButton-isSelected"
   >
     <span
@@ -72,7 +69,6 @@ exports[`EuiSideNavItem preserves child's classes 1`] = `
   class="euiSideNavItem"
 >
   <div
-    aria-label="[object Object]"
     class="euiSideNavItemButton"
   >
     <span

diff --git a/src/components/side_nav/side_nav.js b/src/components/side_nav/side_nav.js
@@ -106,9 +106,7 @@ export class EuiSideNav extends Component {
         </button>
 
         {/* Hidden from view in mobile, but toggled from the button above */}
-        <div className="euiSideNav__content" role="menubar">
-          {nav}
-        </div>
+        <div className="euiSideNav__content">{nav}</div>
       </nav>
     );
   }

diff --git a/src/components/side_nav/side_nav_item.js b/src/components/side_nav/side_nav_item.js
@@ -7,32 +7,22 @@ import { EuiIcon } from '../icon';
 const defaultRenderItem = ({ href, onClick, className, children, ...rest }) => {
   if (href) {
     return (
-      <a
-        className={className}
-        href={href}
-        onClick={onClick}
-        role="menuitem"
-        {...rest}>
+      <a className={className} href={href} onClick={onClick} {...rest}>
         {children}
       </a>
     );
   }
 
   if (onClick) {
     return (
-      <button
-        type="button"
-        className={className}
-        onClick={onClick}
-        role="menuitem"
-        {...rest}>
+      <button type="button" className={className} onClick={onClick} {...rest}>
         {children}
       </button>
     );
   }
 
   return (
-    <div className={className} aria-label={children} {...rest}>
+    <div className={className} {...rest}>
       {children}
     </div>
   );