Skip to content

Commit

Permalink
Passed buffer as 0 to fix extra gap in EuiSuperSelect (#3685)
Browse files Browse the repository at this point in the history
* Passed buffer as 0 to fix extra gap in superselect

* Updated changelog

* Improving changelog

* Snapshots

Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
  • Loading branch information
shrey and elizabetdev authored Jul 2, 2020
1 parent 82e2ee4 commit 62b5d94
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ No public interface changes since `26.2.0`.
- Fixed `EuiSkipLink` interactive props and Safari click issue ([#3665](https://github.com/elastic/eui/pull/3665))
- Fixed `z-index` issues with `EuiHeader`, `EuiFlyout`, and other portal content ([#3655](https://github.com/elastic/eui/pull/3655))
- Fixed `color` prop error in `EuiBadge` to be more flexible with what format it accepts ([#3655](https://github.com/elastic/eui/pull/3655))
- Fixed `EuiSuperSelect` popover from moving 16px horizontally when it's close to a window edge ([#3685](https://github.com/elastic/eui/pull/3685))

**Theme: Amsterdam**

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ exports[`EuiColorPalettePicker more props are propagated to each option 2`] = `
>
<EuiPopover
anchorPosition="downCenter"
buffer={0}
button={
<EuiSuperSelectControl
className="euiSuperSelect--isOpen__button"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,7 @@ exports[`EuiSuperSelect props more props are propogated to each option 2`] = `
>
<EuiPopover
anchorPosition="downCenter"
buffer={0}
button={
<EuiSuperSelectControl
className="euiSuperSelect--isOpen__button"
Expand Down
3 changes: 2 additions & 1 deletion src/components/form/super_select/super_select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ export class EuiSuperSelect<T extends string> extends Component<
anchorPosition="downCenter"
ownFocus={false}
popoverRef={this.setPopoverRef}
hasArrow={false}>
hasArrow={false}
buffer={0}>
<EuiScreenReaderOnly>
<p role="alert">
<EuiI18n
Expand Down

0 comments on commit 62b5d94

Please sign in to comment.