[PR feedback] aria-expanded

elastic · Feb 7, 2024 · 6b0cc92 · 6b0cc92
1 parent 1845fbf
commit 6b0cc92
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/changelogs/upcoming/7513.md b/changelogs/upcoming/7513.md
@@ -1,3 +1,7 @@
+**Bug fixes**
+
+- Fixed an `EuiTreeView` bug where `aria-expanded` was being applied to items without expandable children
+
 **CSS-in-JS conversions**
 
 - Converted `EuiTreeView` to Emotion. Updates as part of the conversion:

diff --git a/src/components/tree_view/__snapshots__/tree_view.test.tsx.snap b/src/components/tree_view/__snapshots__/tree_view.test.tsx.snap
@@ -48,7 +48,6 @@ exports[`EuiTreeView is rendered 1`] = `
             class="euiTreeView__node emotion-euiTreeView__node-default"
           >
             <button
-              aria-expanded="false"
               class="euiTreeView__nodeInner emotion-euiTreeView__nodeInner-default"
               data-test-subj="euiTreeViewButton-euiTreeView_generated-id"
               id="item_a"
@@ -128,7 +127,6 @@ exports[`EuiTreeView is rendered 1`] = `
       class="euiTreeView__node emotion-euiTreeView__node-default"
     >
       <button
-        aria-expanded="false"
         class="euiTreeView__nodeInner emotion-euiTreeView__nodeInner-default"
         data-test-subj="euiTreeViewButton-euiTreeView_generated-id"
         id="item_two"

diff --git a/src/components/tree_view/tree_view.tsx b/src/components/tree_view/tree_view.tsx
@@ -309,7 +309,9 @@ export class EuiTreeViewClass extends Component<
           {items.map((node, index) => {
             const buttonId = node.id;
             const wrappingId = this.treeIdGenerator(buttonId);
-            const isNodeExpanded = this.isNodeOpen(node);
+            const isNodeExpanded = node.children
+              ? this.isNodeOpen(node)
+              : undefined; // Determines the `aria-expanded` attribute
 
             let icon = node.icon;
             if (node.iconWhenExpanded && isNodeExpanded) {