Addressing PR comments and changelog

elastic · Jul 19, 2018 · 70d817c · 70d817c
1 parent 50ca5f3
commit 70d817c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 ## [`master`](https://github.com/elastic/eui/tree/master)
 
-No public interface changes since `3.1.0`.
+- Added a visual pattern for Kibana's Global Date Picker ([#1026](https://github.com/elastic/eui/pull/1026))
+- Added `responsive` prop to `EuiFlexGrid` ([#1026](https://github.com/elastic/eui/pull/1026))
+- Added `expand` prop to `EuiTabs` and `EuiTabbedContent` ([#1026](https://github.com/elastic/eui/pull/1026))
 
 ## [`3.1.0`](https://github.com/elastic/eui/tree/v3.1.0)
 

diff --git a/src-docs/src/views/date_picker/date_picker_example.js b/src-docs/src/views/date_picker/date_picker_example.js
@@ -11,8 +11,7 @@ import {
   EuiLink,
   EuiDatePicker,
   EuiDatePickerRange,
-  EuiBadge,
-  EuiSpacer,
+  EuiCallOut,
 } from '../../../../src/components';
 
 import DatePicker from './date_picker';
@@ -277,12 +276,14 @@ export const DatePickerExample = {
     }],
     text: (
       <div>
-        <EuiBadge color="warning">Pattern only</EuiBadge>
-        <EuiSpacer />
-        <p>
-            This pattern showcases how to setup the components for Kibana&apos;s
-            global date picker. None of the functionality is actually hooked up.
-        </p>
+        <EuiCallOut color="warning" title="Demo of visual pattern only">
+          <p>
+            This documents a <strong>visual</strong> pattern for the eventual replacement of Kibana&apos;s
+            global date/time picker. It uses all EUI components without any custom styles. However, it
+            currently depends strongly on <EuiLink href="https://reactdatepicker.com/#example-45">react-datepicker&apos;s <code>calendarContainer</code></EuiLink> option
+            which has it&apos;s own problems and limitations (like auto-focus on input stealing focus from inputs inside of popover).
+          </p>
+        </EuiCallOut>
       </div>
     ),
     demo: <GlobalDatePicker />,

diff --git a/src-docs/src/views/date_picker/global_date_picker.js b/src-docs/src/views/date_picker/global_date_picker.js
@@ -190,6 +190,7 @@ export default class extends Component {
         isOpen={this.state.isPopoverOpen}
         closePopover={this.closePopover.bind(this)}
         anchorPosition="downLeft"
+        ownFocus
       >
         <div style={{ width: '400px' }}>
           {this.renderQuickSelect()}