Fixed EuiTextColor props (#4058)

elastic · Sep 21, 2020 · 74fffda · 74fffda
1 parent 7807b7c
commit 74fffda
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@
 - Added footer row to `EuiDataGrid` via the `renderFooterCellValue` prop ([#3770](https://github.com/elastic/eui/pull/3770))
 - Added column header menu to `EuiDataGrid` ([#3087](https://github.com/elastic/eui/pull/3087))
 
+**Bug fixes**
+
+- Fixed `EuiTextColor` playground error due to `color` prop not getting captured by the documentation generator ([#4058](https://github.com/elastic/eui/pull/4058))
+
 ## [`29.0.0`](https://github.com/elastic/eui/tree/v29.0.0)
 
 - Added `.browserslistrc` for global browser support reference ([#4022](https://github.com/elastic/eui/pull/4022))

diff --git a/src/components/text/text_color.tsx b/src/components/text/text_color.tsx
@@ -36,8 +36,10 @@ export type TextColor = keyof typeof colorsToClassNameMap;
 export const COLORS = keysOf(colorsToClassNameMap);
 
 type Props = CommonProps &
-  HTMLAttributes<HTMLDivElement> &
-  HTMLAttributes<HTMLSpanElement> & {
+  Omit<
+    HTMLAttributes<HTMLDivElement> & HTMLAttributes<HTMLSpanElement>,
+    'color'
+  > & {
     color?: TextColor;
     /**
      * Determines the root element
@@ -49,14 +51,15 @@ export const EuiTextColor: FunctionComponent<Props> = ({
   children,
   color = 'default',
   className,
-  component: Component = 'span',
+  component = 'span',
   ...rest
 }) => {
   const classes = classNames(
     'euiTextColor',
     colorsToClassNameMap[color],
     className
   );
+  const Component = component;
 
   return (
     <Component className={classes} {...rest}>