Review feedback

elastic · Sep 27, 2019 · 751ec9a · 751ec9a
1 parent 8c30585
commit 751ec9a
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 26 deletions.
diff --git a/src/components/call_out/call_out.tsx b/src/components/call_out/call_out.tsx
@@ -10,16 +10,13 @@ import { EuiText } from '../text';
 type Color = 'primary' | 'success' | 'warning' | 'danger';
 type Size = 's' | 'm';
 
-export interface EuiCallOutProps {
-  title?: ReactNode;
-  iconType?: IconType;
-  color?: Color;
-  size?: Size;
-}
-
-type Props = CommonProps &
-  EuiCallOutProps &
-  Omit<HTMLAttributes<HTMLDivElement>, 'title'>;
+export type EuiCallOutProps = CommonProps &
+  Omit<HTMLAttributes<HTMLDivElement>, 'title'> & {
+    title?: ReactNode;
+    iconType?: IconType;
+    color?: Color;
+    size?: Size;
+  };
 
 const colorToClassNameMap: { [color in Color]: string } = {
   primary: 'euiCallOut--primary',
@@ -35,9 +32,7 @@ const sizeToClassNameMap: { [size in Size]: string } = {
   m: '',
 };
 
-export const SIZES = Object.keys(sizeToClassNameMap);
-
-export const EuiCallOut: FunctionComponent<Props> = ({
+export const EuiCallOut: FunctionComponent<EuiCallOutProps> = ({
   title,
   color = 'primary',
   size = 'm',

diff --git a/src/components/facet/facet_group.tsx b/src/components/facet/facet_group.tsx
@@ -1,7 +1,7 @@
 import React, { FunctionComponent, HTMLAttributes } from 'react';
 import classNames from 'classnames';
 
-import { CommonProps, keysOf } from '../common';
+import { CommonProps } from '../common';
 import { EuiFlexGroup } from '../flex';
 
 type FacetGroupLayout = 'vertical' | 'horizontal';
@@ -11,15 +11,12 @@ const layoutToClassNameMap: { [layout in FacetGroupLayout]: string } = {
   horizontal: 'euiFacetGroup--horizontal',
 };
 
-export const LAYOUTS = keysOf(layoutToClassNameMap);
+export type EuiFacetGroupProps = CommonProps &
+  HTMLAttributes<HTMLDivElement> & {
+    layout?: FacetGroupLayout;
+  };
 
-export interface EuiFacetGroupProps {
-  layout?: FacetGroupLayout;
-}
-
-type Props = CommonProps & HTMLAttributes<HTMLDivElement> & EuiFacetGroupProps;
-
-export const EuiFacetGroup: FunctionComponent<Props> = ({
+export const EuiFacetGroup: FunctionComponent<EuiFacetGroupProps> = ({
   children,
   className,
   layout = 'vertical',

diff --git a/src/components/key_pad_menu/key_pad_menu.tsx b/src/components/key_pad_menu/key_pad_menu.tsx
@@ -3,9 +3,9 @@ import classNames from 'classnames';
 
 import { CommonProps } from '../common';
 
-type Props = CommonProps & HTMLAttributes<HTMLDivElement>;
+export type EuiKeyPadMenuProps = CommonProps & HTMLAttributes<HTMLDivElement>;
 
-export const EuiKeyPadMenu: FunctionComponent<Props> = ({
+export const EuiKeyPadMenu: FunctionComponent<EuiKeyPadMenuProps> = ({
   children,
   className,
   ...rest

diff --git a/src/components/key_pad_menu/key_pad_menu_item.tsx b/src/components/key_pad_menu/key_pad_menu_item.tsx
@@ -58,7 +58,7 @@ interface EuiKeyPadMenuItemCommonProps {
   betaBadgeTooltipContent?: ReactNode;
 }
 
-type EuiKeyPadMenuItemProps = CommonProps &
+export type EuiKeyPadMenuItemProps = CommonProps &
   AnchorHTMLAttributes<HTMLAnchorElement> &
   EuiKeyPadMenuItemCommonProps;
 
@@ -113,7 +113,7 @@ export const EuiKeyPadMenuItem: FunctionComponent<EuiKeyPadMenuItemProps> = ({
   );
 };
 
-type EuiKeyPadMenuItemButtonProps = CommonProps &
+export type EuiKeyPadMenuItemButtonProps = CommonProps &
   ButtonHTMLAttributes<HTMLButtonElement> &
   EuiKeyPadMenuItemCommonProps;