narrow context menu item icon type to only eui iconType variants and …

…ReactElement
elastic · May 31, 2024 · bbf6e95 · bbf6e95
1 parent 3eda6af
commit bbf6e95
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/eui/changelogs/upcoming/7804.md b/packages/eui/changelogs/upcoming/7804.md
@@ -0,0 +1 @@
+- Modify `EuiContextMenuItemIcon` type definition to explicitly define support for EuiIcon's icon definition (i.e `IconType`)
diff --git a/packages/eui/src/components/context_menu/context_menu_item.tsx b/packages/eui/src/components/context_menu/context_menu_item.tsx
@@ -25,12 +25,12 @@ import {
 } from '../../services';
 import { validateHref } from '../../services/security/href_validator';
 import { CommonProps, keysOf } from '../common';
-import { EuiIcon } from '../icon';
+import { EuiIcon, type IconType } from '../icon';
 import { EuiToolTip, EuiToolTipProps } from '../tool_tip';
 
 import { euiContextMenuItemStyles } from './context_menu_item.styles';
 
-export type EuiContextMenuItemIcon = ReactElement<any> | string | HTMLElement;
+export type EuiContextMenuItemIcon = IconType | ReactElement<any>;
 
 export type EuiContextMenuItemLayoutAlignment = 'center' | 'top' | 'bottom';
 
@@ -124,7 +124,7 @@ export const EuiContextMenuItem: FunctionComponent<Props> = ({
       />
     ) : (
       // Assume it's already an instance of an icon.
-      cloneElementWithCss(icon as ReactElement, {
+      cloneElementWithCss(icon, {
         css: styles.euiContextMenu__icon,
       })
     ));
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		- Modify `EuiContextMenuItemIcon` type definition to explicitly define support for EuiIcon's icon definition (i.e `IconType`)