[EuiSuperDatePicker] date popover onChange should only accept strings (…

…#3460) * restrict to string; return iso string * handleChange interface * CL
elastic · May 14, 2020 · c1a6ae2 · c1a6ae2
1 parent eab1f14
commit c1a6ae2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@
 **Bug Fixes**
 
 - Fixed `EuiSuperDatePicker` quick selection menu overriding specified time range with default values ([#3446](https://github.com/elastic/eui/pull/3446))
+- Fixed `EuiDatePopoverContent` `onChange` event to only accept `string` date input  ([#3460](https://github.com/elastic/eui/pull/3460))
 
 **Breaking changes**
 

diff --git a/src/components/date_picker/super_date_picker/date_popover/absolute_tab.tsx b/src/components/date_picker/super_date_picker/date_popover/absolute_tab.tsx
@@ -23,7 +23,7 @@ import moment, { Moment, LocaleSpecifier } from 'moment'; // eslint-disable-line
 
 import dateMath from '@elastic/datemath';
 
-import { EuiDatePicker } from '../../date_picker';
+import { EuiDatePicker, EuiDatePickerProps } from '../../date_picker';
 import { EuiFormRow, EuiFieldText, EuiFormLabel } from '../../../form';
 import { toSentenceCase } from '../../../../services/string/to_case';
 import { EuiDatePopoverContentProps } from './date_popover_content';
@@ -73,12 +73,12 @@ export class EuiAbsoluteTab extends Component<
     };
   }
 
-  handleChange: EuiDatePopoverContentProps['onChange'] = (date, event) => {
+  handleChange: EuiDatePickerProps['onChange'] = (date, event) => {
     const { onChange } = this.props;
     if (date === null) {
       return;
     }
-    onChange(typeof date === 'string' ? date : date.toISOString(), event);
+    onChange(date.toISOString(), event);
 
     const valueAsMoment = moment(date);
     this.setState({
@@ -97,7 +97,7 @@ export class EuiAbsoluteTab extends Component<
     );
     const dateIsValid = valueAsMoment.isValid();
     if (dateIsValid) {
-      onChange(valueAsMoment, event);
+      onChange(valueAsMoment.toISOString(), event);
     }
     this.setState({
       textInputValue: event.target.value as string,

diff --git a/src/components/date_picker/super_date_picker/date_popover/date_popover_content.tsx b/src/components/date_picker/super_date_picker/date_popover/date_popover_content.tsx
@@ -32,14 +32,11 @@ import {
   toAbsoluteString,
   toRelativeString,
 } from '../date_modes';
-import { Moment, LocaleSpecifier } from 'moment'; // eslint-disable-line import/named
+import { LocaleSpecifier } from 'moment'; // eslint-disable-line import/named
 
 export interface EuiDatePopoverContentProps {
   value: string;
-  onChange(
-    date: Moment | string | null,
-    event?: React.SyntheticEvent<any>
-  ): void;
+  onChange(date: string | null, event?: React.SyntheticEvent<any>): void;
   roundUp?: boolean;
   dateFormat: string;
   timeFormat: string;