Skip to content

Commit

Permalink
EuiTablePagination: Adds data-test-subj to the EuiContextMenuItem (#2778
Browse files Browse the repository at this point in the history
)

* Adds data-test-subj to the EuiContextMenuItem component rendered in EuiTablePagination

* Changes how the data-test-subj value is set

* Adds CHANGELOG line
  • Loading branch information
ffknob authored and chandlerprall committed Jan 21, 2020
1 parent d9273d6 commit c9dcfb3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Converted `EuiFilterButton` to TypeScript ([#2761](https://github.com/elastic/eui/pull/2761))
- Converted `EuiFilterSelectItem` to TypeScript ([#2761](https://github.com/elastic/eui/pull/2761))
- Converted `EuiFieldSearch` to TypeScript ([#2775](https://github.com/elastic/eui/pull/2775))
- Added `data-test-subj` to the `EuiContextMenuItem` in `EuiTablePagination` ([#2778](https://github.com/elastic/eui/pull/2778))

**Bug fixes**

Expand Down
3 changes: 2 additions & 1 deletion src/components/table/table_pagination/table_pagination.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ export class EuiTablePagination extends Component<Props, State> {
onClick={() => {
this.closePopover();
onChangeItemsPerPage(itemsPerPageOption);
}}>
}}
data-test-subj={`tablePagination-${itemsPerPageOption}-rows`}>
<EuiI18n
token="euiTablePagination.rowsPerPageOption"
values={{ rowsPerPage: itemsPerPageOption }}
Expand Down

0 comments on commit c9dcfb3

Please sign in to comment.