Charts team review feedback and upgrade to 19.2.0

elastic · May 7, 2020 · d553f98 · d553f98
1 parent b1eba12
commit d553f98
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -82,7 +82,7 @@
     "@babel/preset-env": "^7.8.3",
     "@babel/preset-react": "^7.8.3",
     "@babel/preset-typescript": "^7.8.3",
-    "@elastic/charts": "^18.3.0",
+    "@elastic/charts": "^19.2.0",
     "@elastic/datemath": "^5.0.2",
     "@elastic/eslint-config-kibana": "^0.15.0",
     "@svgr/core": "5.0.1",

diff --git a/src-docs/src/views/elastic_charts/pie_example.js b/src-docs/src/views/elastic_charts/pie_example.js
@@ -248,7 +248,7 @@ const euiPartitionConfig = euiChartTheme.partition;
     valueFormatter={() => ''} // Hide the slice value if data values are already in percentages
     layers={[
       {
-        groupByRollup: d => d.language,
+        groupByRollup: d => d.category,
         shape: {
           fillColor: d => euiChartTheme.theme.colors.vizColors[d.sortIndex],
         },
@@ -319,8 +319,8 @@ const euiPartitionConfig = euiChartTheme.partition;
           <p>
             Multi-level pie charts (also known as sunbursts) and treemaps are
             great for visualizing hierarchical relationships and for quickly
-            referencing the overall data comparison. However, they’re terrible
-            for displaying a true understanding of the values.
+            referencing the overall data comparison. However, they’re not meant
+            to represent trends or explicit/detailed value comparison.
           </p>
           <p>
             Below are some basic examples and how EUI supports them with

diff --git a/src-docs/src/views/elastic_charts/treemap.js b/src-docs/src/views/elastic_charts/treemap.js
@@ -93,12 +93,12 @@ export default () => {
               data={GITHUB_DATASET_MOD}
               valueAccessor={d => d.count}
               valueGetter="percent"
+              topGroove={0}
               layers={[
                 {
                   groupByRollup: d => d.vizType,
                   shape: {
-                    fillColor: d =>
-                      groupedPalette[d.sortIndex * 3 + d.sortIndex],
+                    fillColor: d => groupedPalette[d.sortIndex * 3],
                   },
                   fillLabel: {
                     valueFormatter: () => '',

diff --git a/yarn.lock b/yarn.lock
@@ -993,10 +993,10 @@
     lodash "^4.17.13"
     to-fast-properties "^2.0.0"
 
-"@elastic/charts@^18.3.0":
-  version "18.3.0"
-  resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-18.3.0.tgz#cbdeec1860af274edc7a5f5b9dd26ec48c64bb64"
-  integrity sha512-4kSlSwdDRsVKVX8vRUkwxOu1IT6WIepgLnP0OZT7cFjgrC1SV/16c3YLw2NZDaVe0M/H4rpeNWW30VyrzZVhyw==
+"@elastic/charts@^19.2.0":
+  version "19.2.0"
+  resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-19.2.0.tgz#45db8c80e4699e5088a1771f190171c1144c5242"
+  integrity sha512-uhk73OQPaxg7l54gfr+kv+c6jiEngewwH408OySzJbnH23z/5sIpLSziZhV33I6bs/LKDXQSqamC9Jh6Xcwk1A==
   dependencies:
     classnames "^2.2.6"
     d3-array "^1.2.4"