Addressing PR comments

- Added <dl> to example - fixed typo
elastic · Apr 18, 2018 · eaffebc · eaffebc
1 parent 87de5a2
commit eaffebc
Show file tree

Hide file tree

Showing 4 changed files with 53 additions and 7 deletions.
diff --git a/src-docs/src/views/text/text.js b/src-docs/src/views/text/text.js
@@ -2,6 +2,7 @@ import React from 'react';
 
 import {
   EuiText,
+  EuiHorizontalRule,
 } from '../../../../src/components';
 
 export default () => (
@@ -100,6 +101,29 @@ export default () => (
       </p>
 
       <h6>This is Heading Six</h6>
+
+      <EuiHorizontalRule />
+
+      <dl>
+        <dt>
+          The Elder Scrolls: Morrowind
+        </dt>
+        <dd>
+          The opening music alone evokes such strong memories.
+        </dd>
+        <dt>
+          TIE Fighter
+        </dt>
+        <dd>
+          The sequel to XWING, join the dark side and fly for the Emporer.
+        </dd>
+        <dt>
+          Quake 2
+        </dt>
+        <dd>
+          The game that made me drop out of college.
+        </dd>
+      </dl>
     </EuiText>
   </div>
 );
diff --git a/src-docs/src/views/text/text_align.js b/src-docs/src/views/text/text_align.js
@@ -25,7 +25,7 @@ export default () => (
       <p>You can also pass alignment to <EuiCode>EuiText</EuiCode> directly with a prop</p>
     </EuiText>
     <EuiText textAlign="center" color="secondary">
-      <p>And in conjuction with coloring.</p>
+      <p>And in conjunction with coloring.</p>
     </EuiText>
   </div>
 );
diff --git a/src-docs/src/views/text/text_small.js b/src-docs/src/views/text/text_small.js
@@ -4,6 +4,7 @@ import {
   EuiText,
   EuiFlexGroup,
   EuiFlexItem,
+  EuiHorizontalRule,
 } from '../../../../src/components';
 
 const exampleText = (
@@ -88,6 +89,29 @@ const exampleText = (
     </p>
 
     <h6>This is Heading Six</h6>
+
+    <EuiHorizontalRule />
+
+    <dl>
+      <dt>
+        The Elder Scrolls: Morrowind
+      </dt>
+      <dd>
+        The opening music alone evokes such strong memories.
+      </dd>
+      <dt>
+        TIE Fighter
+      </dt>
+      <dd>
+        The sequel to XWING, join the dark side and fly for the Emporer.
+      </dd>
+      <dt>
+        Quake 2
+      </dt>
+      <dd>
+        The game that made me drop out of college.
+      </dd>
+    </dl>
   </div>
 );
 

diff --git a/src/components/text/_text.scss b/src/components/text/_text.scss
@@ -55,7 +55,8 @@
     line-height: convertToRem($baseLineHeightMultiplier * 4);
   }
 
-  h4 {
+  h4,
+  dt {
     font-size: convertToRem($baseFontSize * nth($euiTextScale, 5)); // skip level 4 on purpose
   }
 
@@ -110,10 +111,6 @@
     list-style: decimal;
   }
 
-  dt {
-    @include euiTitle("xs");
-  }
-
   blockquote {
     position: relative;
     text-align: center;
@@ -156,7 +153,8 @@
     @include euiTitle("s");
   }
 
-  h4 {
+  h4,
+  dt {
     @include euiTitle("xs");
   }