Skip to content

Commit

Permalink
[Amsterdam] Eui(Dual)Range styles (#4815)
Browse files Browse the repository at this point in the history
* Adding initial range amsterdam styles

* WIP

* wip

* wip

* cross browser fixes

* Using Sass variables

* Safari the new IE 11 :P

* Levels with less with than track

* Adding thumb focus ring

* Adjusting ticks colors after merging master

* Removing hover animation

* Styling levels

* align ticks to thumb

* Adding focus state and changing highlight color

* Reverting examples

* Reverting examples

* wip

* Fixing tooltip position and better focus state

* Highlight focus only if no input

* Adding CL

* color stops fix

* Better thumbs for hue, color stops and range slider

* Focus with more constrast

* Moving CL to the master section.

* Only border around the thumb using the focus $euiFocusRingColor

* Removing unnecessary styles

* Adding focus highlight only on keyboard focus

* Fixing disabled state

* Moving EuiRangeHighlight after EuiRangeSlider to better highlight sibling on focus

* Merged upstream/master

* Adding dragabble amsterdam styles

* Adding inline color picker thumb with transparency

* Removing on click focus for color stop. Click focus only for safari.

* Removing outline for range slider in Safari.

* update custom termminal tick offset

* Update src/themes/eui-amsterdam/global_styling/mixins/_range.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src/themes/eui-amsterdam/overrides/_hue.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Better focus states for Safari

* Removing unnecessary style

* Fixing CL after merge

* Better positioning tooltips for range wiht ticks

* Update CHANGELOG.md

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Preventing a flash of the outline in Safari

* Replacing $euiAnimSpeedFast with $euiAnimSpeedExtraFast

Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
  • Loading branch information
3 people authored Jun 17, 2021
1 parent 816f3e5 commit fb286cb
Show file tree
Hide file tree
Showing 30 changed files with 770 additions and 226 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@

**Bug fixes**

- Fixed `EuiRange` container expansion due to negative margin value ([#4815](https://github.com/elastic/eui/pull/4815))
- Fixed `EuiRange` ticks position to better align with thumbs ([#4815](https://github.com/elastic/eui/pull/4815))
- Fixed DataGrid footer and header rows jumps in Firefox ([#4869](https://github.com/elastic/eui/issues/4869))

**Theme: Amsterdam**

- Updated styles for `EuiRange` ([#4815](https://github.com/elastic/eui/pull/4815)
- Fixed more unique focus states using `outline` ([#4876](https://github.com/elastic/eui/pull/4876))
- Fixed `border-radius` value of `EuiPanel` ([#4876](https://github.com/elastic/eui/pull/4876))
- Fixed `disabled` background color of `EuiCard` for better visiblity on subdued backgrounds ([#4876](https://github.com/elastic/eui/pull/4876))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ exports[`renders compressed EuiColorStops 1`] = `
Test: Color stop picker. Each stop consists of a number and corresponding color value. Use the Down and Up arrow keys to select individual stops. Press the Enter key to create a new stop.
</p>
<div
class="euiRangeTrack"
class="euiRangeTrack euiRangeTrack--compressed"
>
<div
class="euiRangeHighlight euiRangeHighlight--compressed euiColorStops__highlight"
Expand Down
3 changes: 1 addition & 2 deletions src/components/color_picker/color_stops/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@
import { getEventPosition, getChromaColor } from '../utils';
import { DEFAULT_VISUALIZATION_COLOR } from '../../../services';
import { ColorStop } from './color_stop_thumb';

const EUI_THUMB_SIZE = 16; // Same as $euiRangeThumbHeight & $euiRangeThumbWidth
import { EUI_THUMB_SIZE } from '../../form/range/utils';

export const removeStop = (colorStops: ColorStop[], index: number) => {
if (colorStops.length === 1) {
Expand Down
Loading

0 comments on commit fb286cb

Please sign in to comment.