-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiInputPopover] In fixed container (like flyout) has positioning issues #1023
Comments
It will probably be fixed if they then use the |
Shouldn't need the |
This is likely to be fixed by the popover watching for dynamic content in #966, will be merged soon. |
Dave verified this is resolved in the latest EUI version. |
I am seeing this issue in the latest Kibana and EUI The color picker positioning is messed up in a flyout. To reproduce, put a color picker in a flyout. Scroll the flyout before opening the color picker. Open the color picker. Notice that it opens at the old location of the anchor and not the new location. Also, the EuiComboBox menu does not stay with the input when scrolled in a flyout |
We should look into the combo box (and probably check the super select too), but the color picker will never work until we re-write the component to use our own popovers. Right now it's just using an absolutely positioned "pop up" and not our portalled popover since it's using an external library. |
For reference, #856 is the WIP custom color picker PR |
The above example is not an EuiComboBox but an EuiSuperSelect. EuiComboBoxes are fixed by auto-closing on scroll. Likely we'll want to do the same for EuiSuperSelect. |
Hello there. I created a minimum app. https://codesandbox.io/s/tvrux and https://tvrux.csb.app/ is preview page. The app has two sections. Each section has two button, one is eui and another is react-bootstrap. And all the situation are expected as this comment mentions #1563 (comment)
In my app, the functionality of fullscreen is needed. But, react-bootstrap using popper library (https://popper.js.org/), and this library has react version (https://popper.js.org/react-popper). I also trace both library. eui only calc Finally, I wonder that would you think about using |
Another instance (elastic/kibana#108869) with reproduction (https://codesandbox.io/s/damp-wave-mpikw) |
We'll want to get this fixed before FF. cc @bmcconaghy so he's aware we're on it.
The text was updated successfully, but these errors were encountered: