Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Pressing enter after searching can throw an error #1176

Closed
stacey-gammon opened this issue Sep 10, 2018 · 1 comment
Closed
Labels
bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible

Comments

@stacey-gammon
Copy link
Contributor

Hitting this in tests so I'm guessing it's a timing issue. Ran kbn yan clean && yarn kbn bootstrap to assure it's not a bad cache issue.

screen shot 2018-09-10 at 9 22 30 am

See elastic/kibana#22233 for some more context.

To repro I added await PageObjects.common.pressEnterKey(); in the combobox service, in the set function to get around the above but then hit this issue when running input control selenium tests.

I'm thinking maybe an async timing issue which matchingOptions and options? Actually I see:

    if (areOptionsDifferent) {
      this.options = [];
      this.setState({ matchingOptions: newMatchingOptions });

      if (!newMatchingOptions.length) {
        // Prevent endless setState -> componentWillUpdate -> setState loop.
        if (this.state.hasActiveOption) {
          this.clearActiveOption();
        }
      }
    }

Which seems like then options might be an empty array but matchingOptions might not in which case I could see how it would get hit.

@chandlerprall chandlerprall added the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Sep 18, 2020
@cchaos cchaos changed the title Pressing enter in combobox after searching can throw an error [EuiComboBox] Pressing enter after searching can throw an error Sep 19, 2020
@cee-chen
Copy link
Contributor

Closing this as not reproducible due to the age of the bug. In addition, this issue will likely go away when EuiComboBox is converted to use EuiSelectable (#2841)

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible
Projects
None yet
Development

No branches or pull requests

4 participants