Input Controls have wrong state when typing and hitting enter too fast throws error

[liza-mae]

Kibana version: 6.4. BC6

Elasticsearch version: 6.4 BC6

Server OS version: WIndows

Browser version: Chrome

Browser OS version: Latest

Original install method (e.g. download page, yum, from source, etc.): staging

Describe the bug:
× fail: "visualize app input control visualization updateFiltersOnChange is false should replace existing filter pill(s) when new item is selected"
│ Error: expected true to equal false
│ at Assertion.assert (node_modules\expect.js\index.js:96:13)
│ at Assertion.be.Assertion.equal (node_modules\expect.js\index.js:216:10)
│ at Context.it (C:/Users/vagrant/Final/kibana-6.4/test/functional/apps/visualize/_input_control_vis.js:92:33)
│ at
│ at process._tickCallback (internal/process/next_tick.js:188:7)
│

[liza-mae]

[stacey-gammon]

This is a legit bug.

cc @elastic/kibana-sharing

[stacey-gammon]

In addition, in trying to bypass the bug in the tests, ran into another issue. If you press the enter key too quickly while it's loading up you'll get an error Uncaught TypeError: Cannot read property 'click' of null (http://localhost:5620/bundles/vendors.bundle.js:187778)

[stacey-gammon]

The problem with pressing enter I believe is an issue in EUI, but input controls has it's own issue.

when it searches, it flickers with all the options before being filtered:

ListControl.render options: [{"label":"css","value":"css"},{"label":"gif","value":"gif"},{"label":"jpg","value":"jpg"},{"label":"php","value":"php"},{"label":"png","value":"png"}]
list_control.js:84 ListControl.fetchOptions: c
list_control.js:89 ListControl.fetchOptions returned: c
list_control.js:148 ListControl.render options: [{"label":"css","value":"css"},{"label":"gif","value":"gif"},{"label":"jpg","value":"jpg"},{"label":"php","value":"php"},{"label":"png","value":"png"}]
list_control.js:148 ListControl.render options: [{"label":"css","value":"css"}]

That second to last render with all the options causes a flicker, which also throws off the tests since it tries to click the css that shows up then disappears.

[kertal]

@mbondyra this can be closed, right?

[mbondyra]

@kertal yeah, I will close it - planning on checking today if it in fact solved the issue and then closing it.

[mbondyra]

looks like the test is passing now, closing.