Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EuiFilterButton and EuiFacetButton behave the same #1511

Closed
pickypg opened this issue Feb 2, 2019 · 1 comment · Fixed by #1589
Closed

Make EuiFilterButton and EuiFacetButton behave the same #1511

pickypg opened this issue Feb 2, 2019 · 1 comment · Fixed by #1589
Assignees

Comments

@pickypg
Copy link
Member

pickypg commented Feb 2, 2019

When using EuiFilterButton with numFilters, you get something like

image

And using EuiFilterButton with numFilters plus hasActiveFilters={true}, you get something like

image

But when you use EuiFacetButton with quantity, you get something like

image

And using EuiFacetButton with numFilters plus isSelected={true}, you get something like

image

There are three significant differences between the controls:

  1. The notification badge always displays as "selected" ("active" looking) in the filter button.
  2. The notification badge size is different.
  3. The font-weight is different.

My personal preference is that the EuiFacetButton is behaving better than EuiFilterButton: the font weight is more noticeable and the change in color is very noticeable, and the color is quite distracting / misleading when the EuiFilterButton does not have active filters.

@cchaos
Copy link
Contributor

cchaos commented Feb 4, 2019

I'll agree that these should be aligned in some way since they basically/usually do the same thing just in a different format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants