-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Filter and Facet button styles #1589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought about it, looked at it, abandoned it. Someone more engineery would need to do that bit.
I think the bold weight is a lot easier to notice than an underline and just by way of consistency elsewhere we use underlines to indicate focus state not selected state. |
Ready for another pass @thompsongl |
And equalized look of EuiFacetButton and EuiFilterButton
This reverts commit 8c3059f.
and updated some examples
And removing empty sass file
7e44617
to
b506eab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔜
Fixes #1511
Essentially, this PR aligns the EuiFilterButton styles too look similar to the EuiFacetButton. It also means allowing to pass the "total available filters" when none are selected:
As well as highlight when there are selected filters:
Which meant adding
numActiveFilters
to EuiFilterButton.As a reference, this is what the facet buttons look like
Typescript
I had originally attempted to convert them to TS, but because they each imported a non-TS'd component or the props of one, I couldn't do it. Maybe someone with better TS chops than me can. But I did make sure the TS def's were up to date so it will be easier to convert down the line.
Other
Added some extra props to
EuiNotificationBadge
:size
: s, m (default: s)color
: accent, subdued (default: accent)I also did some quick updates to EuiAvatar (thicker font weight and font size adjustment) and to EuiIcon so that both do never shrink because of flex.
I also added a global mixin for the text-weight-shifting stuff since we're seeing it more often.
Checklist
[ ] Documentation examples were added[ ] This was checked for breaking changes and labeled appropriately[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components