Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an unlink glyph to EuiIcon #3839

Closed
ThomThomson opened this issue Jul 30, 2020 · 8 comments · Fixed by #3869
Closed

Add an unlink glyph to EuiIcon #3839

ThomThomson opened this issue Jul 30, 2020 · 8 comments · Fixed by #3869
Assignees
Labels

Comments

@ThomThomson
Copy link
Contributor

In adding the unlink from visualize library action to embeddable panels, I realized that EuiIcon glyph collection has a link icon, but no unlink icon.

This could also be used for unlink from saved search.

Something similar to this icon from fontawesome:

Screen Shot 2020-07-30 at 5 18 02 PM

@elizabetdev elizabetdev self-assigned this Jul 31, 2020
@elizabetdev
Copy link
Contributor

@ThomThomson thanks for suggesting this icon.

I started working on this issue. I tried to create an icon that would match the link icon. So in case, we would click from link to unlink it would look it's being transformed from one to another.

Screenshot 2020-08-04 at 16 39 49

I did some tests here:
https://codesandbox.io/s/silly-ramanujan-tpsjo?file=/index.js

@chaos do you think one of these options would work?

@cchaos
Copy link
Contributor

cchaos commented Aug 4, 2020

Can you paste the screenshots of these at 100% zoom level to see how they look at their actual 16x16 size?

@elizabetdev
Copy link
Contributor

@chaos, you can also see them here already transformed into react components: https://codesandbox.io/s/silly-ramanujan-tpsjo?file=/index.js.

Screenshot 2020-08-04 at 17 29 06

@cchaos
Copy link
Contributor

cchaos commented Aug 4, 2020

My main thought is that they all still look very similar to the original link icon. Using the slash could still be interpreted as the connector of the two links. I would try to make it more dissimilar / make the break more pronounced.

@elizabetdev
Copy link
Contributor

@chaos what do you think of one of these two (3 and 4)?

Screenshot 2020-08-05 at 14 34 43

Screenshot 2020-08-05 at 14 33 50

@cchaos
Copy link
Contributor

cchaos commented Aug 5, 2020

I'm diggin the last one because it gives movement to the original, especially when used together in a toggle button. And it's a little more unique than the quintessential one from the PR summary.

@ThomThomson
Copy link
Contributor Author

@miukimiu, #4 looks great!

@elizabetdev
Copy link
Contributor

Thanks for the feedback. I'm going to open a PR with the last option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants