Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unlink glyph to EuiIcon #3869

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Conversation

elizabetdev
Copy link
Contributor

@elizabetdev elizabetdev commented Aug 5, 2020

Summary

Closes #3839.

This PR adds an unlink glyph to EuiIcon.

Dark and light themes

unlink@2x

Design

Screenshot 2020-08-05 at 20 03 25

In action!

Screen Recording 2020-08-05 at 07 58 PM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in IE11 and Firefox~~
  • [ ] Props have proper autodocs
  • Added documentation examples
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elizabetdev elizabetdev requested a review from cchaos August 5, 2020 19:12
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3869/

@cchaos
Copy link
Contributor

cchaos commented Aug 5, 2020

I think you caught a flakey test... Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3869/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@elizabetdev elizabetdev merged commit 150a1c1 into elastic:master Aug 6, 2020
nyurik pushed a commit that referenced this pull request Aug 18, 2020
* Added unlink glyph to EuiIcon

* Snapshot

* CL number. Updating design.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an unlink glyph to EuiIcon
3 participants